Bug 186571 – Complex text handling should opt out of bounded text layout.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

<rdar://problem/40801429>

[zalan]

Created attachment 342573 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 342573 [details]
Patch

Clearing flags on attachment: 342573

Committed r232774: <https://trac.webkit.org/changeset/232774>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41060908>

[Ryan Haddad]

Reverted r232774 for reason:

Breaks internal builds.

Committed r232784: <https://trac.webkit.org/changeset/232784>

[zalan]

Created attachment 342621 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 342621 [details]
Patch

Clearing flags on attachment: 342621

Committed r232787: <https://trac.webkit.org/changeset/232787>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 342621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342621&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm:147
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 101400) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED == 120000)

How can == be right here? Surely it should be >= instead.

I think need to update CoreTextSPI.h so people without access to CoreTextPriv.h can build on macOS Mojave and newer.

Also, I wasn’t able to build locally; maybe that means I need an updated version of the Apple internal headers. I didn’t see any announcement about that for Apple engineers.

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 342829 [details]
Patch

[Jonathan Bedard]

A few notes: Darin is right, we need to update CoreTextSPI. This will also break building on Seed 1, I'm verifying this fix with Seed 2. I talked with Zalan this morning, the '==' is right, at least for the time being.  See Ryan's rollout.

[Jonathan Bedard]

Comment on attachment 342829 [details]
Patch

Verified this on Seed 2

[EWS Watchlist]

Comment on attachment 342829 [details]
Patch

Attachment 342829 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8201362

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 342838 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Jonathan Bedard]

Comment on attachment 342829 [details]
Patch

Tree is red for Windows tests, landing.

[WebKit Commit Bot]

Comment on attachment 342829 [details]
Patch

Clearing flags on attachment: 342829

Committed r232894: <https://trac.webkit.org/changeset/232894>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

(In reply to Jonathan Bedard from comment #12)
> I talked with Zalan this morning, the '==' is right, at least for the time being.

Are you or Zalan able to explain why "==" is correct?

[Jonathan Bedard]

(In reply to Daniel Bates from comment #19)
> (In reply to Jonathan Bedard from comment #12)
> > I talked with Zalan this morning, the '==' is right, at least for the time being.
> 
> Are you or Zalan able to explain why "==" is correct?

It had to do with which SDK the SPI was available...been more than a year since I looked at it, though. With deprecation of the iOS 12 builders, and the fact that we are only supporting the Mojave G release now, this code should be dead.