Bug 186565 – Rebaseline WebCrypto API tests for High Sierra after r232641

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dawei Fenton (:realdawei)]

Rebaseline the following tests after r232641

imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker.html

[Dawei Fenton (:realdawei)]

Created attachment 342551 [details]
Patch

[Ryan Haddad]

On what platforms is this test failing?

[Dawei Fenton (:realdawei)]

(In reply to Ryan Haddad from comment #2)
> On what platforms is this test failing?

High Sierra

[EWS Watchlist]

Comment on attachment 342551 [details]
Patch

Attachment 342551 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/8148627

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker.html

[EWS Watchlist]

Created attachment 342556 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Jiewen Tan]

(In reply to David Fenton from comment #3)
> (In reply to Ryan Haddad from comment #2)
> > On what platforms is this test failing?
> 
> High Sierra

That is expected behavior as RSA-PSS is only supported for High Sierra/iOS11+.

[Jiewen Tan]

(In reply to Jiewen Tan from comment #6)
> (In reply to David Fenton from comment #3)
> > (In reply to Ryan Haddad from comment #2)
> > > On what platforms is this test failing?
> > 
> > High Sierra
> 
> That is expected behavior as RSA-PSS is only supported for High
> Sierra/iOS11+.

And our EWS bots and bunch of others are not in High Sierra yet. So we need two different versions of expected files for RSA-PSS tests.

[EWS Watchlist]

Comment on attachment 342551 [details]
Patch

Attachment 342551 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8149384

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker.html

[EWS Watchlist]

Created attachment 342571 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 342551 [details]
Patch

Attachment 342551 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8149367

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker.html

[EWS Watchlist]

Created attachment 342574 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Dawei Fenton (:realdawei)]

Created attachment 342587 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 342587 [details]
Patch

Rejecting attachment 342587 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 342587, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/8151079

[Dawei Fenton (:realdawei)]

Created attachment 342589 [details]
Patch

[Ryan Haddad]

Comment on attachment 342589 [details]
Patch

Trying again.

[WebKit Commit Bot]

Comment on attachment 342589 [details]
Patch

Clearing flags on attachment: 342589

Committed r232772: <https://trac.webkit.org/changeset/232772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41059917>

[Ryan Haddad]

Follow up to add missing whitespace in https://trac.webkit.org/r232781.