Bug 186559 - [GTK] Enable tests on the GTK EWS queue
Summary: [GTK] Enable tests on the GTK EWS queue
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on: 186843
Blocks:
  Show dependency tree / graph
 
Reported: 2018-06-12 04:42 PDT by Carlos Alberto Lopez Perez
Modified: 2018-06-20 06:50 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.14 KB, patch)
2018-06-12 04:54 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-sierra (3.02 MB, application/zip)
2018-06-12 06:57 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews206 for win-future (12.75 MB, application/zip)
2018-06-13 06:46 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2018-06-12 04:42:48 PDT 
In order to make easier for contributors to get layout test results for the GTK port we will like to enable tests on the EWS queue.
Comment 1 Carlos Alberto Lopez Perez 2018-06-12 04:54:39 PDT 
Created attachment 342525 [details]
Patch
Comment 2 EWS Watchlist 2018-06-12 06:57:27 PDT 
Comment on attachment 342525 [details]
Patch

Attachment 342525 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8146053

New failing tests:
js/dom/JSON-stringify.html
Comment 3 EWS Watchlist 2018-06-12 06:57:28 PDT 
Created attachment 342531 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Michael Catanzaro 2018-06-12 08:43:56 PDT 
Comment on attachment 342525 [details]
Patch

OK, let's see how it goes.
Comment 5 Michael Catanzaro 2018-06-12 08:46:59 PDT 
(In reply to Build Bot from comment #2)
> Comment on attachment 342525 [details]
> Patch
> 
> Attachment 342525 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/8146053
> 
> New failing tests:
> js/dom/JSON-stringify.html

We'll need to do better than Mac at avoiding spam comments caused by flaky tests. :/  Anyway, we can always switch back if it's too much of a problem, so let's give it a try.
Comment 6 Carlos Alberto Lopez Perez 2018-06-12 08:48:58 PDT 
(In reply to Michael Catanzaro from comment #4)
> Comment on attachment 342525 [details]
> Patch
> 
> OK, let's see how it goes.

Thanks for the review.. before landing I think we should do an extra effort to make the release GTK bot green
Comment 7 EWS Watchlist 2018-06-13 06:45:50 PDT 
Comment on attachment 342525 [details]
Patch

Attachment 342525 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8162650

New failing tests:
http/tests/security/local-video-source-from-remote.html
http/tests/preload/onload_event.html
Comment 8 EWS Watchlist 2018-06-13 06:46:01 PDT 
Created attachment 342650 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 9 Carlos Alberto Lopez Perez 2018-06-14 10:56:19 PDT 
Ok.. the GTK bot is now almost green (1 failure as of r232840)

Let's land this now and see how it goes.
Comment 10 Carlos Alberto Lopez Perez 2018-06-14 10:57:28 PDT 
Comment on attachment 342525 [details]
Patch

Clearing flags on attachment: 342525

Committed r232844: <https://trac.webkit.org/changeset/232844>
Comment 11 Carlos Alberto Lopez Perez 2018-06-14 10:57:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2018-06-14 10:59:24 PDT 
<rdar://problem/41131057>
Comment 13 WebKit Commit Bot 2018-06-20 06:50:14 PDT 
Re-opened since this is blocked by bug 186843