RESOLVED FIXED 186548
Experimental Features "CSS Spring Animations" and "Link Preload" should not be active for production builds 
https://bugs.webkit.org/show_bug.cgi?id=186548
Summary Experimental Features "CSS Spring Animations" and "Link Preload" should not b...
Brent Fulgham
Reported 2018-06-11 16:41:57 PDT
The relevant engineers for these two features tell me that they should NOT be enabled by default for production builds: CSS Spring Animations Link Preload
Attachments
Patch (1.62 KB, patch)
2018-06-11 16:46 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (8.55 MB, application/zip)
2018-06-11 18:50 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews205 for win-future (12.80 MB, application/zip)
2018-06-12 01:05 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-06-11 16:43:54 PDT
<rdar://problem/41023774>
Brent Fulgham
Comment 2 2018-06-11 16:46:36 PDT
Created attachment 342485 [details] Patch
EWS Watchlist
Comment 3 2018-06-11 18:50:29 PDT
Comment on attachment 342485 [details] Patch Attachment 342485 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/8139581 New failing tests: http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html
EWS Watchlist
Comment 4 2018-06-11 18:50:30 PDT
Created attachment 342498 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
EWS Watchlist
Comment 5 2018-06-12 01:05:43 PDT
Comment on attachment 342485 [details] Patch Attachment 342485 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8143848 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 6 2018-06-12 01:05:54 PDT
Created attachment 342520 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Brent Fulgham
Comment 7 2018-06-12 12:25:58 PDT
Those test failures were not related to this patch.
Brent Fulgham
Comment 8 2018-06-12 12:48:35 PDT
Comment on attachment 342485 [details] Patch These test failures can't be related, since the EWS build with these changes is identical to the EWS sources without the changes. Only a Production build would see a difference.
WebKit Commit Bot
Comment 9 2018-06-12 13:15:36 PDT
Comment on attachment 342485 [details] Patch Clearing flags on attachment: 342485 Committed r232771: <https://trac.webkit.org/changeset/232771>
WebKit Commit Bot
Comment 10 2018-06-12 13:15:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.