Bug 186546 – http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html times out with PSON enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html & http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html time out with PSON enabled.

[Chris Dumez]

I believe the issue is that we process swap when navigated a frame that has opened a window. This is not OK at the moment because the new window can have a WindowProxy to its opener (which those tests rely on).

We currently prevent PSON if we have an opener, we should also prevent PSON if FrameLoader::m_openedFrames is not empty.

[Chris Dumez]

Created attachment 342476 [details]
Patch

[Brady Eidson]

Comment on attachment 342476 [details]
Patch

Hate having a second copy of the test just for the PSON version... =(

[EWS Watchlist]

Comment on attachment 342476 [details]
Patch

Attachment 342476 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8138653

New failing tests:
fast/css/counters/element-removal-crash.xhtml

[EWS Watchlist]

Created attachment 342493 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Chris Dumez]

(In reply to Brady Eidson from comment #3)
> Comment on attachment 342476 [details]
> Patch
> 
> Hate having a second copy of the test just for the PSON version... =(

We can drop them once PSON is enabled by default.

[WebKit Commit Bot]

Comment on attachment 342476 [details]
Patch

Clearing flags on attachment: 342476

Committed r232737: <https://trac.webkit.org/changeset/232737>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41029496>