Bug 186546 - http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html times out with PSON enabled
Summary: http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html times...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 186542
  Show dependency treegraph
 
Reported: 2018-06-11 15:47 PDT by Chris Dumez
Modified: 2018-06-13 16:31 PDT (History)
7 users (show)

See Also:


Attachments
Patch (14.86 KB, patch)
2018-06-11 16:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-sierra (3.10 MB, application/zip)
2018-06-11 17:53 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-11 15:47:18 PDT
http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html & http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html time out with PSON enabled.
Comment 1 Chris Dumez 2018-06-11 15:52:23 PDT
I believe the issue is that we process swap when navigated a frame that has opened a window. This is not OK at the moment because the new window can have a WindowProxy to its opener (which those tests rely on).

We currently prevent PSON if we have an opener, we should also prevent PSON if FrameLoader::m_openedFrames is not empty.
Comment 2 Chris Dumez 2018-06-11 16:19:45 PDT
Created attachment 342476 [details]
Patch
Comment 3 Brady Eidson 2018-06-11 17:10:34 PDT
Comment on attachment 342476 [details]
Patch

Hate having a second copy of the test just for the PSON version... =(
Comment 4 EWS Watchlist 2018-06-11 17:53:02 PDT
Comment on attachment 342476 [details]
Patch

Attachment 342476 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8138653

New failing tests:
fast/css/counters/element-removal-crash.xhtml
Comment 5 EWS Watchlist 2018-06-11 17:53:03 PDT
Created attachment 342493 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Chris Dumez 2018-06-11 18:00:08 PDT
(In reply to Brady Eidson from comment #3)
> Comment on attachment 342476 [details]
> Patch
> 
> Hate having a second copy of the test just for the PSON version... =(

We can drop them once PSON is enabled by default.
Comment 7 WebKit Commit Bot 2018-06-11 18:28:06 PDT
Comment on attachment 342476 [details]
Patch

Clearing flags on attachment: 342476

Committed r232737: <https://trac.webkit.org/changeset/232737>
Comment 8 WebKit Commit Bot 2018-06-11 18:28:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-06-11 18:29:25 PDT
<rdar://problem/41029496>