Bug 186543 – Make CompletionHandler more const correct

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Make CompletionHandler more const correct

[Alex Christensen]

Created attachment 342470 [details]
Patch

[Alex Christensen]

Created attachment 342483 [details]
Patch

[Michael Catanzaro]

Comment on attachment 342483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342483&action=review

I don't have a strong opinion on whether we should do this, just a nit:

> Source/WTF/wtf/CompletionHandler.h:34
> -// Wraps a WTF::Function to make sure it is always called once and only once.
> +// Wraps a Function to make sure it is always called once and only once on the correct thread.

This change belongs in bug #186171.

[EWS Watchlist]

Comment on attachment 342483 [details]
Patch

Attachment 342483 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8141424

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html

[EWS Watchlist]

Created attachment 342513 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Alex Christensen]

Created attachment 342567 [details]
Patch

[Alex Christensen]

Created attachment 342609 [details]
Patch

[EWS Watchlist]

Comment on attachment 342609 [details]
Patch

Attachment 342609 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8156705

New failing tests:
http/tests/security/local-video-source-from-remote.html
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 342635 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Alex Christensen]

I think the windows failures are unrelated.

[Alex Christensen]

Created attachment 345959 [details]
Patch

[Saam Barati]

Comment on attachment 345959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345959&action=review

> Source/WTF/wtf/CompletionHandler.h:56
> +    Out operator()(In... in)

I think for perfect forwarding you want (In&... in)

[Alex Christensen]

(In reply to Saam Barati from comment #12)
> Comment on attachment 345959 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345959&action=review
> 
> > Source/WTF/wtf/CompletionHandler.h:56
> > +    Out operator()(In... in)
> 
> I think for perfect forwarding you want (In&... in)

Right now it's the same as WTF::Function.  Let's change both of them in another patch if it does anything.

[Alex Christensen]

https://trac.webkit.org/changeset/234332/webkit

[Radar WebKit Bug Importer]

<rdar://problem/42677497>