Bug 186541 – Unpainted area while scrolling in Reader is white

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Unpainted area while scrolling in Reader is white

[Tim Horton]

Created attachment 342466 [details]
Patch

[Tim Horton]

<rdar://problem/40471363>

[EWS Watchlist]

Comment on attachment 342466 [details]
Patch

Attachment 342466 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8136386

New failing tests:
tiled-drawing/fixed-layout-size-fixed-attachment-cover.html
tiled-drawing/background-transparency-toggle.html
tiled-drawing/fixed-layout-size-fixed-attachment-local.html

[EWS Watchlist]

Created attachment 342473 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Tim Horton]

Created attachment 342518 [details]
Patch

[EWS Watchlist]

Comment on attachment 342518 [details]
Patch

Attachment 342518 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8145981

New failing tests:
http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html

[EWS Watchlist]

Created attachment 342530 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Tim Horton]

Created attachment 342577 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 342577 [details]
Patch

Clearing flags on attachment: 342577

Committed r232991: <https://trac.webkit.org/changeset/232991>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

Comment on attachment 342577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342577&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3148
> +        if (!m_layerForOverhangAreas)
> +            return;

Wait what? You're skipping the setRootLayerConfigurationNeedsUpdate() stuff below.

[Tim Horton]

(In reply to Simon Fraser (smfr) from comment #11)
> Comment on attachment 342577 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342577&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:3148
> > +        if (!m_layerForOverhangAreas)
> > +            return;
> 
> Wait what? You're skipping the setRootLayerConfigurationNeedsUpdate() stuff
> below.

Err, yeah, that needs to only bail from the stuff inside that block