Bug 186538 - Add ByteString as a string that adheres to WebIDL ByteString constraints
Summary: Add ByteString as a string that adheres to WebIDL ByteString constraints
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-11 13:33 PDT by youenn fablet
Modified: 2022-09-03 06:39 PDT (History)
9 users (show)

See Also:


Attachments
Patch (35.76 KB, patch)
2018-06-11 13:57 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Fixing compilation (35.77 KB, patch)
2018-06-11 16:47 PDT, youenn fablet
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-sierra (3.44 MB, application/zip)
2018-06-11 19:15 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-06-11 13:33:37 PDT
This will allow to tighten/optimize the code a bit.
Comment 1 youenn fablet 2018-06-11 13:57:37 PDT
Created attachment 342462 [details]
Patch
Comment 2 Chris Dumez 2018-06-11 14:07:37 PDT
Comment on attachment 342462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342462&action=review

> Source/WebCore/ChangeLog:8
> +        Modify IDL conversion to instantiate WTF::ByteString instead of WTF::String.

Is it really worth adding yet one more string type? This is not required for correct behavior since the JS bindings already dealt with ByteString correctly. I am personally not convinced this is an improvement and find it surprising with add Web IDL concepts in WTF.
Comment 3 youenn fablet 2018-06-11 16:47:16 PDT
Created attachment 342486 [details]
Fixing compilation
Comment 4 EWS Watchlist 2018-06-11 19:15:18 PDT
Comment on attachment 342486 [details]
Fixing compilation

Attachment 342486 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8140083

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/overridemimetype-blob.html
Comment 5 EWS Watchlist 2018-06-11 19:15:20 PDT
Created attachment 342502 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Ahmad Saleem 2022-09-03 06:38:51 PDT
Is this needed anymore? Unfortunately, it didn't had any test case in the attached patch so I couldn't check. :-(

Just trying to close old bugs etc., so don't mind my bumps. Thanks!