Bug 186529 - Disable some vestibular trigger animations when prefers-reduced-motion is active.
Summary: Disable some vestibular trigger animations when prefers-reduced-motion is act...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-11 10:53 PDT by James Craig
Modified: 2018-07-24 10:33 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.56 KB, patch)
2018-06-14 13:44 PDT, Jon Davis
no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2018-07-13 13:53 PDT, Jon Davis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.80 MB, application/zip)
2018-07-13 16:46 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2018-06-11 10:53:50 PDT
Disable some vestibular trigger animations when prefers-reduced-motion is active. For example, the blog post text floats upward right after a page load.

Regression since the time that this post went live.
https://webkit.org/blog/7551/responsive-design-for-motion/
Comment 1 Jon Davis 2018-06-14 13:44:13 PDT
Created attachment 342758 [details]
Patch
Comment 2 James Craig 2018-07-13 13:14:30 PDT
Comment on attachment 342758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342758&action=review

There are a bunch of whitespace-only diffs that should not be in this patch.

> Websites/webkit.org/wp-content/themes/webkit/style.css:1709
> +    article,

Do you really want this on all article elements? Maybe this style sheet already has limited inclusion? I'm okay with this if you're sure, but I'd expect you'd want to limit the motion (and subsequent reduction) to the primary article on blog posts only: Looks like the article has a post classname. e.g. selector could be `article.post { ... }`
Comment 3 Jon Davis 2018-07-13 13:53:15 PDT
Created attachment 344977 [details]
Patch
Comment 4 Jon Davis 2018-07-13 13:56:47 PDT
> Do you really want this on all article elements? Maybe this style sheet already has limited inclusion? I'm okay with this if you're sure, but I'd expect you'd want to limit the motion (and subsequent reduction) to the primary article on blog posts only: Looks like the article has a post classname. e.g. selector could be `article.post { ... }`

Yes, it should be on all article elements and the feature status page. This is a consistent page load animation across all content pages and posts on webkit.org. The motion should be replaced everywhere it is applied.
Comment 5 EWS Watchlist 2018-07-13 16:46:38 PDT
Comment on attachment 344977 [details]
Patch

Attachment 344977 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8530553

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html
Comment 6 EWS Watchlist 2018-07-13 16:46:49 PDT
Created attachment 345003 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 WebKit Commit Bot 2018-07-24 10:31:25 PDT
Comment on attachment 344977 [details]
Patch

Clearing flags on attachment: 344977

Committed r234155: <https://trac.webkit.org/changeset/234155>
Comment 8 WebKit Commit Bot 2018-07-24 10:31:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-07-24 10:33:27 PDT
<rdar://problem/42546539>