We sometimes see slow cache retrieves in logs. Add some more logging for these cases.
<rdar://problem/41002070>
Created attachment 342423 [details] patch
Created attachment 342424 [details] patch
Attachment 342424 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:83: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 342427 [details] patch
Created attachment 342428 [details] patch
Attachment 342428 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:83: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 342428 [details] patch Shouldn't all these WallTimes be MonotonicTimes? I don't think we want logs that claim large time values or negative time values when the user crosses daylight savings time or syncs with Apple's time server or something like that.
> Shouldn't all these WallTimes be MonotonicTimes? Yeah, I'll do that.
Created attachment 342455 [details] patch
Attachment 342455 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:84: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 342455 [details] patch Clearing flags on attachment: 342455 Committed r232759: <https://trac.webkit.org/changeset/232759>
All reviewed patches have been landed. Closing bug.