RESOLVED FIXED 186520
Add performance logging for slow cache retrieves 
https://bugs.webkit.org/show_bug.cgi?id=186520
Summary Add performance logging for slow cache retrieves
Antti Koivisto
Reported 2018-06-11 06:28:19 PDT
We sometimes see slow cache retrieves in logs. Add some more logging for these cases.
Attachments
patch (22.17 KB, patch)
2018-06-11 06:43 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (22.31 KB, patch)
2018-06-11 06:53 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (22.37 KB, patch)
2018-06-11 07:01 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (22.36 KB, patch)
2018-06-11 07:01 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (22.67 KB, patch)
2018-06-11 12:38 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-06-11 06:28:35 PDT
<rdar://problem/41002070>
Antti Koivisto
Comment 2 2018-06-11 06:43:04 PDT
Created attachment 342423 [details] patch
Antti Koivisto
Comment 3 2018-06-11 06:53:52 PDT
Created attachment 342424 [details] patch
EWS Watchlist
Comment 4 2018-06-11 07:00:22 PDT
Attachment 342424 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:83: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 5 2018-06-11 07:01:18 PDT
Created attachment 342427 [details] patch
Antti Koivisto
Comment 6 2018-06-11 07:01:58 PDT
Created attachment 342428 [details] patch
EWS Watchlist
Comment 7 2018-06-11 07:03:34 PDT
Attachment 342428 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:83: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 8 2018-06-11 09:30:41 PDT
Comment on attachment 342428 [details] patch Shouldn't all these WallTimes be MonotonicTimes? I don't think we want logs that claim large time values or negative time values when the user crosses daylight savings time or syncs with Apple's time server or something like that.
Antti Koivisto
Comment 9 2018-06-11 09:56:50 PDT
> Shouldn't all these WallTimes be MonotonicTimes? Yeah, I'll do that.
Antti Koivisto
Comment 10 2018-06-11 12:38:06 PDT
Created attachment 342455 [details] patch
EWS Watchlist
Comment 11 2018-06-11 12:39:05 PDT
Attachment 342455 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:84: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 12 2018-06-12 10:53:08 PDT
Comment on attachment 342455 [details] patch Clearing flags on attachment: 342455 Committed r232759: <https://trac.webkit.org/changeset/232759>
WebKit Commit Bot
Comment 13 2018-06-12 10:53:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.