Bug 186520 - Add performance logging for slow cache retrieves
Summary: Add performance logging for slow cache retrieves
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-11 06:28 PDT by Antti Koivisto
Modified: 2018-06-12 10:53 PDT (History)
7 users (show)

See Also:


Attachments
patch (22.17 KB, patch)
2018-06-11 06:43 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (22.31 KB, patch)
2018-06-11 06:53 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (22.37 KB, patch)
2018-06-11 07:01 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (22.36 KB, patch)
2018-06-11 07:01 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (22.67 KB, patch)
2018-06-11 12:38 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-06-11 06:28:19 PDT
We sometimes see slow cache retrieves in logs. Add some more logging for these cases.
Comment 1 Antti Koivisto 2018-06-11 06:28:35 PDT
<rdar://problem/41002070>
Comment 2 Antti Koivisto 2018-06-11 06:43:04 PDT
Created attachment 342423 [details]
patch
Comment 3 Antti Koivisto 2018-06-11 06:53:52 PDT
Created attachment 342424 [details]
patch
Comment 4 Build Bot 2018-06-11 07:00:22 PDT
Attachment 342424 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Antti Koivisto 2018-06-11 07:01:18 PDT
Created attachment 342427 [details]
patch
Comment 6 Antti Koivisto 2018-06-11 07:01:58 PDT
Created attachment 342428 [details]
patch
Comment 7 Build Bot 2018-06-11 07:03:34 PDT
Attachment 342428 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Geoffrey Garen 2018-06-11 09:30:41 PDT
Comment on attachment 342428 [details]
patch

Shouldn't all these WallTimes be MonotonicTimes?

I don't think we want logs that claim large time values or negative time values when the user crosses daylight savings time or syncs with Apple's time server or something like that.
Comment 9 Antti Koivisto 2018-06-11 09:56:50 PDT
> Shouldn't all these WallTimes be MonotonicTimes?

Yeah, I'll do that.
Comment 10 Antti Koivisto 2018-06-11 12:38:06 PDT
Created attachment 342455 [details]
patch
Comment 11 Build Bot 2018-06-11 12:39:05 PDT
Attachment 342455 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 WebKit Commit Bot 2018-06-12 10:53:08 PDT
Comment on attachment 342455 [details]
patch

Clearing flags on attachment: 342455

Committed r232759: <https://trac.webkit.org/changeset/232759>
Comment 13 WebKit Commit Bot 2018-06-12 10:53:09 PDT
All reviewed patches have been landed.  Closing bug.