Bug 186501 – [Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

The WPT test at imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html is failing reliably, flaky or timing out.

[Radar WebKit Bug Importer]

<rdar://problem/41000224>

[Antoine Quint]

Created attachment 344728 [details]
Patch

[EWS Watchlist]

Attachment 344728 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:178:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 344728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344728&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:293
> +        // When calling processKeyframeLikeObject() with the "allow lists" flag set to false, the only alternatives
> +        // we should expect are double and nullptr.

The only offset alternatives.

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:300
> +        // When calling processKeyframeLikeObject() with the "allow lists" flag set to false, the only alternative
> +        // we should expect is String.

The only easing alternative

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:305
> +        // When calling processKeyframeLikeObject() with the "allow lists" flag set to false, the only alternatives
> +        // we should expect are CompositeOperation and nullptr.

The only composite alternatives

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:325
> +    RETURN_IF_EXCEPTION(scope, Exception { TypeError });

Why do you need this? Wouldn't the exception have been thrown in the inner scope (the forEach)? I don't think anything else could throw in this scope.

[Antoine Quint]

Committed r233729: <https://trac.webkit.org/changeset/233729>

[Antoine Quint]

Committed r233730: <https://trac.webkit.org/changeset/233730>

[Antoine Quint]

Committed r233731: <https://trac.webkit.org/changeset/233731>