Bug 186501 - [Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably
Summary: [Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-11 04:39 PDT by Antoine Quint
Modified: 2018-07-11 09:40 PDT (History)
6 users (show)

See Also:


Attachments
Patch (20.66 KB, patch)
2018-07-10 16:02 PDT, Antoine Quint
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-06-11 04:39:34 PDT
The WPT test at imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html is failing reliably, flaky or timing out.
Comment 1 Radar WebKit Bug Importer 2018-06-11 04:39:48 PDT
<rdar://problem/41000224>
Comment 2 Antoine Quint 2018-07-10 16:02:52 PDT
Created attachment 344728 [details]
Patch
Comment 3 EWS Watchlist 2018-07-10 16:05:42 PDT
Attachment 344728 [details] did not pass style-queue:


ERROR: Source/WebCore/animation/KeyframeEffectReadOnly.cpp:178:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dean Jackson 2018-07-10 19:13:30 PDT
Comment on attachment 344728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344728&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:293
> +        // When calling processKeyframeLikeObject() with the "allow lists" flag set to false, the only alternatives
> +        // we should expect are double and nullptr.

The only offset alternatives.

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:300
> +        // When calling processKeyframeLikeObject() with the "allow lists" flag set to false, the only alternative
> +        // we should expect is String.

The only easing alternative

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:305
> +        // When calling processKeyframeLikeObject() with the "allow lists" flag set to false, the only alternatives
> +        // we should expect are CompositeOperation and nullptr.

The only composite alternatives

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:325
> +    RETURN_IF_EXCEPTION(scope, Exception { TypeError });

Why do you need this? Wouldn't the exception have been thrown in the inner scope (the forEach)? I don't think anything else could throw in this scope.
Comment 5 Antoine Quint 2018-07-11 08:54:09 PDT
Committed r233729: <https://trac.webkit.org/changeset/233729>
Comment 6 Antoine Quint 2018-07-11 09:34:44 PDT
Committed r233730: <https://trac.webkit.org/changeset/233730>
Comment 7 Antoine Quint 2018-07-11 09:40:33 PDT
Committed r233731: <https://trac.webkit.org/changeset/233731>