Bug 186481 - [GStreamer] flush video sample upon DRAIN query
Summary: [GStreamer] flush video sample upon DRAIN query
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on: 186599
Blocks:
  Show dependency tree / graph
 
Reported: 2018-06-11 03:19 PDT by Philippe Normand
Modified: 2018-06-13 10:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2018-06-11 03:26 PDT, Philippe Normand 		calvaris: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.76 MB, application/zip)
2018-06-11 08:37 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-06-11 03:19:47 PDT 
.
Comment 1 Philippe Normand 2018-06-11 03:26:42 PDT 
Created attachment 342415 [details]
Patch
Comment 2 Enrique Ocaña 2018-06-11 04:47:47 PDT 
I don't remember if this caused regressions with some layout tests which expected the last frame to be available. Better check it.
Comment 3 Philippe Normand 2018-06-11 06:52:34 PDT 
I checked it. No regression detected!
Comment 4 EWS Watchlist 2018-06-11 08:37:19 PDT 
Comment on attachment 342415 [details]
Patch

Attachment 342415 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8127912

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 5 EWS Watchlist 2018-06-11 08:37:33 PDT 
Created attachment 342435 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Philippe Normand 2018-06-12 02:43:20 PDT 
Committed r232747: <https://trac.webkit.org/changeset/232747>
Comment 7 Radar WebKit Bug Importer 2018-06-12 02:45:13 PDT 
<rdar://problem/41038703>