RESOLVED FIXED 186479
[MotionMark] Add support for version numbers
https://bugs.webkit.org/show_bug.cgi?id=186479
Summary [MotionMark] Add support for version numbers
Jon Lee
Reported 2018-06-10 23:12:52 PDT
[MotionMark] Add support for version numbers
Attachments
Patch (20.10 KB, patch)
2018-06-11 09:43 PDT, Jon Lee
no flags
Archive of layout-test-results from ews202 for win-future (12.89 MB, application/zip)
2018-06-12 06:33 PDT, EWS Watchlist
no flags
Jon Lee
Comment 1 2018-06-11 09:43:21 PDT
Said Abou-Hallawa
Comment 2 2018-06-11 10:11:12 PDT
Comment on attachment 342438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342438&action=review > PerformanceTests/MotionMark/about.html:40 > + <div class="logo"><svg><use xlink:href="resources/runner/logo.svg#root" /></svg></div> I am not sure why we have to create an <svg> element which has a <use> element and this element references a target in an eternal <svg> especially there is only a single symbol in the logo.svg. Can't be just use <img width="525" height="130" src="logo.svg">? And of course get rid of the <symbol> tag from logo.svg.
EWS Watchlist
Comment 3 2018-06-12 06:33:16 PDT
Comment on attachment 342438 [details] Patch Attachment 342438 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8145813 New failing tests: http/tests/preload/onload_event.html http/tests/security/video-poster-cross-origin-crash2.html
EWS Watchlist
Comment 4 2018-06-12 06:33:27 PDT
Created attachment 342529 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Jon Lee
Comment 5 2018-06-25 08:38:20 PDT
Comment on attachment 342438 [details] Patch Clearing flags on attachment: 342438 Committed r233147: <https://trac.webkit.org/changeset/233147>
Jon Lee
Comment 6 2018-06-25 08:38:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-06-25 08:40:52 PDT
Note You need to log in before you can comment on or make changes to this bug.