Bug 186479 - [MotionMark] Add support for version numbers
Summary: [MotionMark] Add support for version numbers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-10 23:12 PDT by Jon Lee
Modified: 2018-06-25 08:40 PDT (History)
6 users (show)

See Also:


Attachments
Patch (20.10 KB, patch)
2018-06-11 09:43 PDT, Jon Lee
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.89 MB, application/zip)
2018-06-12 06:33 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2018-06-10 23:12:52 PDT
[MotionMark] Add support for version numbers
Comment 1 Jon Lee 2018-06-11 09:43:21 PDT
Created attachment 342438 [details]
Patch
Comment 2 Said Abou-Hallawa 2018-06-11 10:11:12 PDT
Comment on attachment 342438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342438&action=review

> PerformanceTests/MotionMark/about.html:40
> +        <div class="logo"><svg><use xlink:href="resources/runner/logo.svg#root" /></svg></div>

I am not sure why we have to create an <svg> element which has a <use> element and this element references a target in an eternal <svg> especially there is only a single symbol in the logo.svg. Can't be just use

<img width="525" height="130" src="logo.svg">? And of course get rid of the <symbol> tag from logo.svg.
Comment 3 EWS Watchlist 2018-06-12 06:33:16 PDT
Comment on attachment 342438 [details]
Patch

Attachment 342438 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8145813

New failing tests:
http/tests/preload/onload_event.html
http/tests/security/video-poster-cross-origin-crash2.html
Comment 4 EWS Watchlist 2018-06-12 06:33:27 PDT
Created attachment 342529 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Jon Lee 2018-06-25 08:38:20 PDT
Comment on attachment 342438 [details]
Patch

Clearing flags on attachment: 342438

Committed r233147: <https://trac.webkit.org/changeset/233147>
Comment 6 Jon Lee 2018-06-25 08:38:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-06-25 08:40:52 PDT
<rdar://problem/41425283>