Bug 186478 - [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API
Summary: [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 184770
  Show dependency treegraph
 
Reported: 2018-06-10 23:02 PDT by Fujii Hironori
Modified: 2018-06-11 12:00 PDT (History)
9 users (show)

See Also:


Attachments
Patch (21.42 KB, patch)
2018-06-10 23:17 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-06-10 23:02:26 PDT
[Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API
Comment 1 Fujii Hironori 2018-06-10 23:17:04 PDT
Created attachment 342411 [details]
Patch
Comment 2 Build Bot 2018-06-10 23:18:45 PDT
Attachment 342411 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:25:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:26:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/MiniBrowserLibResource.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-06-11 11:59:27 PDT
Comment on attachment 342411 [details]
Patch

Clearing flags on attachment: 342411

Committed r232723: <https://trac.webkit.org/changeset/232723>
Comment 4 WebKit Commit Bot 2018-06-11 11:59:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-11 12:00:30 PDT
<rdar://problem/41013896>