MediaTrackCapabilities.deviceId and groupId are not hashed.
Created attachment 342381 [details] Patch
Can we add a tes validating that track ids match enuerateDevice ids?
(In reply to youenn fablet from comment #2) > Can we add a tes validating that track ids match enuerateDevice ids? I'll try to add an assertion to MediaStreamTrack-getCapabilities.html.
Created attachment 342412 [details] Patch
Comment on attachment 342412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342412&action=review Thank you for the fix! > LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:47 > + if(trackKind !== 'audio' && trackKind !== 'video') Nit: tests typically have a space between "if" and "(" > LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:51 > + if(deviceInfo.deviceId === deviceId && deviceInfo.kind === deviceKind) { Ditto. > LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:89 > + },e => { Nit: missing a space between "," and "e"
Created attachment 342500 [details] Patch
Comment on attachment 342500 [details] Patch r=me
Jianjun - for future reference, a patch doesn't *need* another review once a reviewer give it an "r+". Replace "NOBODY (OOPS!)" with the reviewer's name before you upload the revised patch, mark it "cq?" and any committer can mark it "cq+"
Comment on attachment 342500 [details] Patch Clearing flags on attachment: 342500 Committed r232754: <https://trac.webkit.org/changeset/232754>
All reviewed patches have been landed. Closing bug.
<rdar://problem/41046888>
Eric, thanks for reviewing the patch and letting me know the review process.