Bug 186464 - REGRESSION (r230480): Cannot adjust photo position on LinkedIn's profile page
Summary: REGRESSION (r230480): Cannot adjust photo position on LinkedIn's profile page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-09 13:47 PDT by zalan
Modified: 2018-06-09 18:28 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.59 KB, patch)
2018-06-09 14:02 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.77 MB, application/zip)
2018-06-09 17:24 PDT, EWS Watchlist
no flags Details
Patch (5.52 KB, patch)
2018-06-09 17:38 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-06-09 13:47:58 PDT
rdar://problem/40369448
Comment 1 zalan 2018-06-09 14:02:21 PDT
Created attachment 342370 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-06-09 16:32:08 PDT
Comment on attachment 342370 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342370&action=review

> LayoutTests/fast/images/positioned-image-when-transform-is-present-expected.html:1
> +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">

Wut.

> LayoutTests/fast/images/positioned-image-when-transform-is-present.html:1
> +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">

Wut.
Comment 3 zalan 2018-06-09 16:42:58 PDT
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 342370 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342370&action=review
> 
> > LayoutTests/fast/images/positioned-image-when-transform-is-present-expected.html:1
> > +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">
> 
> Wut.
> 
> > LayoutTests/fast/images/positioned-image-when-transform-is-present.html:1
> > +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">
> 
> Wut.
lol copypaste
Comment 4 EWS Watchlist 2018-06-09 17:24:39 PDT
Comment on attachment 342370 [details]
Patch

Attachment 342370 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8104426

New failing tests:
http/tests/security/local-video-source-from-remote.html
Comment 5 EWS Watchlist 2018-06-09 17:24:50 PDT
Created attachment 342373 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 zalan 2018-06-09 17:38:40 PDT
Created attachment 342375 [details]
Patch
Comment 7 WebKit Commit Bot 2018-06-09 18:26:59 PDT
Comment on attachment 342375 [details]
Patch

Clearing flags on attachment: 342375

Committed r232663: <https://trac.webkit.org/changeset/232663>
Comment 8 WebKit Commit Bot 2018-06-09 18:27:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-06-09 18:28:10 PDT
<rdar://problem/40974886>