Bug 186463 - [Xcode] Clean up and modernize some build setting definitions
Summary: [Xcode] Clean up and modernize some build setting definitions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-09 12:04 PDT by mitz
Modified: 2018-06-09 22:19 PDT (History)
14 users (show)

See Also:


Attachments
Patch to see if anything breaks (8.91 KB, patch)
2018-06-09 12:04 PDT, mitz
no flags Details | Formatted Diff | Diff
Patch to see if anything breaks (8.98 KB, patch)
2018-06-09 12:11 PDT, mitz
no flags Details | Formatted Diff | Diff
Patch to see if anything breaksh (58.05 KB, patch)
2018-06-09 19:05 PDT, mitz
no flags Details | Formatted Diff | Diff
Clean up and modernize (70.05 KB, patch)
2018-06-09 21:11 PDT, mitz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2018-06-09 12:04:13 PDT
Some build setting definitions are unused or unnecessarily complex.
Comment 1 mitz 2018-06-09 12:04:35 PDT
Created attachment 342368 [details]
Patch to see if anything breaks
Comment 2 mitz 2018-06-09 12:11:58 PDT
Created attachment 342369 [details]
Patch to see if anything breaks
Comment 3 mitz 2018-06-09 19:05:59 PDT
Created attachment 342377 [details]
Patch to see if anything breaksh
Comment 4 Build Bot 2018-06-09 19:51:51 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 5 mitz 2018-06-09 21:11:11 PDT
Created attachment 342379 [details]
Clean up and modernize
Comment 6 WebKit Commit Bot 2018-06-09 22:18:15 PDT
Comment on attachment 342379 [details]
Clean up and modernize

Clearing flags on attachment: 342379

Committed r232665: <https://trac.webkit.org/changeset/232665>
Comment 7 WebKit Commit Bot 2018-06-09 22:18:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-06-09 22:19:17 PDT
<rdar://problem/40976906>