RESOLVED FIXED186458
[JSC] Array.prototype.sort should rejects null comparator 
https://bugs.webkit.org/show_bug.cgi?id=186458
Summary [JSC] Array.prototype.sort should rejects null comparator
Yusuke Suzuki
Reported 2018-06-09 02:37:07 PDT
[JSC] Array.prototype.sort should rejects null comparator
Attachments
Patch (5.80 KB, patch)
2018-06-09 02:41 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-06-09 02:41:10 PDT
Created attachment 342364 [details] Patch
Keith Miller
Comment 2 2018-06-09 22:58:54 PDT
Comment on attachment 342364 [details] Patch ha! How times change... r=me.
Yusuke Suzuki
Comment 3 2018-06-10 00:10:11 PDT
Comment on attachment 342364 [details] Patch Thanks
WebKit Commit Bot
Comment 4 2018-06-10 00:36:46 PDT
Comment on attachment 342364 [details] Patch Clearing flags on attachment: 342364 Committed r232666: <https://trac.webkit.org/changeset/232666>
WebKit Commit Bot
Comment 5 2018-06-10 00:36:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-06-10 00:37:20 PDT
<rdar://problem/40978395>
Dawei Fenton (:realdawei)
Comment 7 2018-06-11 13:32:54 PDT
Looks like we have some new test262 errors after this revision: Sample Output: ! NEW FAIL test/built-ins/Array/prototype/sort/comparefn-nonfunction-call-throws.js (strict mode) ! NEW FAIL test/built-ins/Array/prototype/sort/comparefn-nonfunction-call-throws.js (default) https://build.webkit.org/builders/Apple%20Sierra%20Debug%20Test262%20%28Tests%29/builds/2822/steps/test262-test/logs/stdio
Yusuke Suzuki
Comment 8 2018-06-12 05:10:03 PDT
Committed r232750: <https://trac.webkit.org/changeset/232750>
Note You need to log in before you can comment on or make changes to this bug.