Bug 186446 – jumpTrueOrFalse only takes the fast path for boolean false

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tadeu Zagallo]

jumpTrueOrFalse did a mask check to take the fast path for boolean literals, but it would only work for false. Change it so that it takes the fast path for true, false and undefined.

[Radar WebKit Bug Importer]

<rdar://problem/40949995>

[Tadeu Zagallo]

Created attachment 342326 [details]
Patch

[Mark Lam]

Comment on attachment 342326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342326&action=review

r=me with fixes.

> Source/JavaScriptCore/ChangeLog:11
> +        the fast path for true, false and undefined.

and null too.  This is only for 64-bit.  For 32-bit, it was already taking the fast path for true or false, and still does for only those 2 values.  Please add this to the ChangeLog comment so that we don't miscommunicate the scope of this change.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1824
> +    btqnz t0, ~15, .slow

nit: I prefer you use ~0xf instead so that we can think in terms of the bits being masked.

[Tadeu Zagallo]

Created attachment 342346 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 342346 [details]
Patch for landing

Clearing flags on attachment: 342346

Committed r232658: <https://trac.webkit.org/changeset/232658>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.