Bug 186445 – [Win] Add IPC error case for broken pipe

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Basuke Suzuki]

Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler.

[Basuke Suzuki]

Created attachment 342323 [details]
PATCH

[EWS Watchlist]

Comment on attachment 342323 [details]
PATCH

Attachment 342323 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8091811

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 342351 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Ryosuke Niwa]

Comment on attachment 342323 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=342323&action=review

> Source/WebKit/ChangeLog:6
> +        Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler.

Can we add some test?

[Basuke Suzuki]

(In reply to Ryosuke Niwa from comment #4)
> Comment on attachment 342323 [details]
> PATCH
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342323&action=review
> 
> > Source/WebKit/ChangeLog:6
> > +        Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler.
> 
> Can we add some test?

Ironically this patch is to run TestWebKit correctly. With this patch applied, it runs one step further to the goal so that means it works as expected. I wanna postpone this by opening a new bug for testing this. Does that make sense for you? >Ryosuke

[Basuke Suzuki]

Created attachment 342774 [details]
FIX

I'll open a new bug to refactor IPC::Connection for Win soon. Thanks for r+ > Ryosuke

[WebKit Commit Bot]

Comment on attachment 342774 [details]
FIX

Clearing flags on attachment: 342774

Committed r232860: <https://trac.webkit.org/changeset/232860>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41145073>