Bug 186442 – [WebKit on watchOS] Upstream watchOS source additions to OpenSource

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Wenson Hsieh]

<rdar://problem/40879364>

[Wenson Hsieh]

Created attachment 342317 [details]
Patch

[Wenson Hsieh]

Created attachment 342355 [details]
Patch for landing

[EWS Watchlist]

Comment on attachment 342317 [details]
Patch

Attachment 342317 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8094262

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 342357 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 342355 [details]
Patch for landing

Clearing flags on attachment: 342355

Committed r232659: <https://trac.webkit.org/changeset/232659>

[Wenson Hsieh]

Reopening to attach new patch.

[Wenson Hsieh]

Created attachment 342570 [details]
Form controls

[Tim Horton]

Comment on attachment 342570 [details]
Form controls

View in context: https://bugs.webkit.org/attachment.cgi?id=342570&action=review

> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:647
> +    if (pickerView == _yearAndEraPicker)
> +        [_yearAndEraPicker setChangingValue:YES];
> +    if (pickerView == _dayPicker)

else if?

> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:655
> +    if (pickerView == _yearAndEraPicker)

Ditto

> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:145
> +- (void)_handleKeyPress:(WKNumberPadKey)key

This is not my favorite thing in the world, but OK.

> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:258
> +    fadeOutAnimation.fromValue = @(1);

Do you need the parens?

> Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm:67
> +    [_dateFormatter setLocale:[NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]];

en_US_POSIX, always?

[Wenson Hsieh]

Comment on attachment 342570 [details]
Form controls

View in context: https://bugs.webkit.org/attachment.cgi?id=342570&action=review

>> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:647
>> +    if (pickerView == _dayPicker)
> 
> else if?

Sounds good.

>> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:655
>> +    if (pickerView == _yearAndEraPicker)
> 
> Ditto

Done!

>> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:145
>> +- (void)_handleKeyPress:(WKNumberPadKey)key
> 
> This is not my favorite thing in the world, but OK.

I'm definitely taking suggestions! :/

>> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:258
>> +    fadeOutAnimation.fromValue = @(1);
> 
> Do you need the parens?

Nope! Removed.

>> Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm:67
>> +    [_dateFormatter setLocale:[NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]];
> 
> en_US_POSIX, always?

Yes. This is just used to transform hour and minute values into an input value (also see: -[WKDateTimePicker dateFormatterForPicker] on iOS).

[Wenson Hsieh]

Created attachment 342581 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 342581 [details]
Patch for landing

Clearing flags on attachment: 342581

Committed r232770: <https://trac.webkit.org/changeset/232770>

[Wenson Hsieh]

Created attachment 342908 [details]
Rename more references to extra zoom

[WebKit Commit Bot]

Comment on attachment 342908 [details]
Rename more references to extra zoom

Clearing flags on attachment: 342908

Committed r232916: <https://trac.webkit.org/changeset/232916>