Bug 186440 - http/tests/navigation/https-no-store-subframe-in-page-cache.html fails with PSON enabled
Summary: http/tests/navigation/https-no-store-subframe-in-page-cache.html fails with P...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Blocks: 186542
  Show dependency treegraph
Reported: 2018-06-08 13:01 PDT by Chris Dumez
Modified: 2018-06-13 16:30 PDT (History)
4 users (show)

See Also:

Patch (2.47 KB, patch)
2018-06-08 13:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-08 13:01:04 PDT
http/tests/navigation/https-no-store-subframe-in-page-cache.html fails with PSON enabled:
--- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/http/tests/navigation/https-no-store-subframe-in-page-cache-expected.txt
+++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/http/tests/navigation/https-no-store-subframe-in-page-cache-actual.txt
@@ -1,3 +1,3 @@
 ALERT: This page is https and has has a subframe with the no-store cache-control directive. It should go in to the page cache.
-ALERT: PASS: The page was restored from the page cache. Good job!
+ALERT: FAIL: The page was reloaded on back. It should NOT have been.

Looks like we fail to restore the page from PageCache.
Comment 1 Chris Dumez 2018-06-08 13:07:56 PDT
Created attachment 342311 [details]
Comment 2 Geoffrey Garen 2018-06-08 13:14:17 PDT
Comment on attachment 342311 [details]

Comment 3 WebKit Commit Bot 2018-06-08 13:59:49 PDT
Comment on attachment 342311 [details]

Clearing flags on attachment: 342311

Committed r232638: <https://trac.webkit.org/changeset/232638>
Comment 4 WebKit Commit Bot 2018-06-08 13:59:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-08 14:00:41 PDT