Bug 186435 – REGRESSION(r230930): Link drag image is very blurry

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

When dragging a link, the link drag image is super blurry.

[Brent Fulgham]

This is more fallout from disconnecting the WebContent process from the WindowServer. The NSImage logic wants to ask the screen for its display scale, but can't and so it defaults to a scale factor of 1.

This causes us to get a 1x image, which is scaled to the actual screen resolution resulting in the blurriness.

I checked the code paths for selection drag, attachment drag, and image drag and all properly address scale factor. It looks like links were the only thing not grabbing scale factor from the device already.

[Brent Fulgham]

We need to help NSImage know the proper scale factor without talking to NSScreen.

[Brent Fulgham]

Created attachment 342283 [details]
Patch

[Tim Horton]

Comment on attachment 342283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342283&action=review

> Source/WebCore/platform/graphics/mac/WebKitNSImageExtras.mm:13
> + * 3.  Neither the name of Apple Inc. ("Apple") nor the names of

This is not the correct license.

> Source/WebCore/platform/graphics/mac/WebKitNSImageExtras.mm:36
> +

Extra newlines?

> Source/WebCore/platform/graphics/mac/WebKitNSImageExtras.mm:38
> +@implementation NSImage (WebKitExtras)

No need for the category to have a name.

[Brent Fulgham]

(In reply to Tim Horton from comment #4)
> Comment on attachment 342283 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342283&action=review
> 
> > Source/WebCore/platform/graphics/mac/WebKitNSImageExtras.mm:13
> > + * 3.  Neither the name of Apple Inc. ("Apple") nor the names of
> 
> This is not the correct license.
> 
> > Source/WebCore/platform/graphics/mac/WebKitNSImageExtras.mm:36
> > +
> 
> Extra newlines?
> 
> > Source/WebCore/platform/graphics/mac/WebKitNSImageExtras.mm:38
> > +@implementation NSImage (WebKitExtras)
> 
> No need for the category to have a name.

Uh oh! And lots of build failures. More work needed!

[Brent Fulgham]

Comment on attachment 342283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342283&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:9315
>  		7A29BA67187B732200F29CEB /* TemporaryOpenGLSetting.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TemporaryOpenGLSetting.h; sourceTree = "<group>"; };

Doh! Stupid Xcode.

[Brent Fulgham]

Created attachment 342285 [details]
Patch for landing

[Brent Fulgham]

Created attachment 342287 [details]
Patch for landing

[Brent Fulgham]

Created attachment 342290 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 342290 [details]
Patch for landing

Clearing flags on attachment: 342290

Committed r232628: <https://trac.webkit.org/changeset/232628>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40944079>

[Brent Fulgham]

This was actually:
<rdar://problem/40797202>