RESOLVED FIXED Bug 18643
SQUIRRELFISH: need to support implicit function calls (valueOf, toString) 
https://bugs.webkit.org/show_bug.cgi?id=18643
Summary SQUIRRELFISH: need to support implicit function calls (valueOf, toString)
Maciej Stachowiak
Reported 2008-04-20 16:36:14 PDT
SquirrelFish does not yet properly handle property getters and setters.
Attachments
Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2008-04-23 13:14:03 PDT
The problem for these implicit function calls (valueOf is called by toNumber, toString by +, etc, getters/setters by resolve) is that they may require a function call in the VM, which may inturn result in resizing of the RegisterFile which would invalidate state in the originating privateExecute frame. Adding the required guards around all call sites would almost certainly be a perf hit but maybe possible at a few places (resolve?)
Cameron Zwarich (cpst)
Comment 2 2008-04-23 21:20:47 PDT
This is causing a lot of failures in the remaining JavaScriptCore test failures, e.g. the instanceof tests. We should really find a way to fix this without too large of a performance regression.
Maciej Stachowiak
Comment 3 2008-04-24 00:50:33 PDT
I'm not sure valueOf / toString are quire the same issue as getters and setters, and we might not want to solve them the exact same way necessarily.
Oliver Hunt
Comment 4 2008-04-29 22:15:40 PDT
Committed r32669 and r32718
Note You need to log in before you can comment on or make changes to this bug.