RESOLVED FIXED 186421
[Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 BrowserWindow
https://bugs.webkit.org/show_bug.cgi?id=186421
Summary [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 ...
Fujii Hironori
Reported 2018-06-07 20:09:37 PDT
[Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 BrowserWindow This is the core patch to make MiniBrowser to support WK1 and WK2 windows (Bug 184770). I will rename MiniBrowser class to WK1BrowserWindow in a follow-up patch (Bug 184770 Comment 12).
Attachments
Patch (10.94 KB, patch)
2018-06-07 20:20 PDT, Fujii Hironori
no flags
Patch (10.93 KB, patch)
2018-06-07 22:05 PDT, Fujii Hironori
no flags
Fujii Hironori
Comment 1 2018-06-07 20:20:50 PDT
Ryosuke Niwa
Comment 2 2018-06-07 21:15:18 PDT
Comment on attachment 342233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342233&action=review > Tools/MiniBrowser/win/PrintWebUIDelegate.cpp:74 > + MiniBrowser* newBrowserWindow = static_cast<MiniBrowser*>(newWindow.browserWindow()); Can we use MiniBrowser& or auto& instead?
Fujii Hironori
Comment 3 2018-06-07 21:17:41 PDT
Comment on attachment 342233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342233&action=review Thank you for the review. >> Tools/MiniBrowser/win/PrintWebUIDelegate.cpp:74 >> + MiniBrowser* newBrowserWindow = static_cast<MiniBrowser*>(newWindow.browserWindow()); > > Can we use MiniBrowser& or auto& instead? Agreed. Will fix with auto&.
Fujii Hironori
Comment 4 2018-06-07 22:05:34 PDT
Fujii Hironori
Comment 5 2018-06-07 22:14:31 PDT
Radar WebKit Bug Importer
Comment 6 2018-06-07 22:15:21 PDT
Darin Adler
Comment 7 2018-06-08 09:32:31 PDT
(In reply to Fujii Hironori from comment #0) > I will rename MiniBrowser class to WK1BrowserWindow in a follow-up patch > (Bug 184770 Comment 12). I don’t think you should do that. The older WebKit programming model is no longer referred to as "WebKit 1" but rather "legacy WebKit" or "WebKitLegacy".
Fujii Hironori
Comment 8 2018-06-08 15:08:09 PDT
(In reply to Darin Adler from comment #7) > (In reply to Fujii Hironori from comment #0) > > I will rename MiniBrowser class to WK1BrowserWindow in a follow-up patch > > (Bug 184770 Comment 12). > > I don’t think you should do that. The older WebKit programming model is no > longer referred to as "WebKit 1" but rather "legacy WebKit" or > "WebKitLegacy". Thank you for the feedback. We are discussing it in Bug 186427.
Note You need to log in before you can comment on or make changes to this bug.