Bug 18641 - SQUIRRELFISH: add support for error nodes
Summary: SQUIRRELFISH: add support for error nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 18624
  Show dependency treegraph
 
Reported: 2008-04-20 16:08 PDT by Cameron Zwarich (cpst)
Modified: 2008-04-20 16:36 PDT (History)
0 users

See Also:


Attachments
Proposed patch (7.50 KB, patch)
2008-04-20 16:11 PDT, Cameron Zwarich (cpst)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-04-20 16:08:35 PDT
SquirrelFish currently doesn't support AssignErrorNode, PrefixErrorNode, and PostfixErrorNode. This causes the JavaScriptCore test ecma/LexicalConventions/7.5-10-n.js to fail.
Comment 1 Cameron Zwarich (cpst) 2008-04-20 16:11:02 PDT
Created attachment 20709 [details]
Proposed patch

Here is a patch that implements support for error nodes. I tested with SunSpider and it showed no change. 

Should I break up lines with the long string constants so they are each on their own line?
Comment 2 Maciej Stachowiak 2008-04-20 16:15:19 PDT
Comment on attachment 20709 [details]
Proposed patch

Assuming this shows no sunspider regression, r=me.
Comment 3 Cameron Zwarich (cpst) 2008-04-20 16:36:48 PDT
Landed in r32283.