Bug 186402 - REGRESSION(r224134) Client certificate challenges don't always appear
Summary: REGRESSION(r224134) Client certificate challenges don't always appear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-07 10:49 PDT by Alex Christensen
Modified: 2018-06-08 08:56 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2018-06-07 10:50 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2018-06-07 11:40 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-06-07 10:49:14 PDT
REGRESSION(r224134) Client certificate challenges don't always appear
Comment 1 Alex Christensen 2018-06-07 10:50:21 PDT
Created attachment 342189 [details]
Patch
Comment 2 Build Bot 2018-06-07 10:52:10 PDT
Attachment 342189 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brian Weinstein 2018-06-07 11:18:28 PDT
Comment on attachment 342189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342189&action=review

> Source/WebKit/NetworkProcess/NetworkLoad.cpp:340
> +    bool isTLSHandshake = m_challenge->protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested

Is it worth pulling m_challenge->protectionSpace().authenticationScheme() into a local?
Comment 4 Alex Christensen 2018-06-07 11:40:01 PDT
Created attachment 342194 [details]
Patch
Comment 5 WebKit Commit Bot 2018-06-07 12:19:38 PDT
Comment on attachment 342194 [details]
Patch

Clearing flags on attachment: 342194

Committed r232594: <https://trac.webkit.org/changeset/232594>
Comment 6 WebKit Commit Bot 2018-06-07 12:19:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-06-07 12:20:21 PDT
<rdar://problem/40905729>