Bug 186400 – bmalloc: Fix 'noreturn' warnings when compiling with -std=gnu++17

• Status: RESOLVED
• Resolution: FIXED
• Component: bmalloc

[David Kilzer (:ddkilzer)]

Fix 'noreturn' warnings when compiling bmalloc with -std=gnu++17:

Source/bmalloc/bmalloc/Scavenger.cpp:363:1: error: function 'threadRunLoop' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn]
{
^

Source/bmalloc/bmalloc/Scavenger.cpp:358:1: error: function 'threadEntryPoint' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn]
{
^

2 errors generated.

[David Kilzer (:ddkilzer)]

Created attachment 342184 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Comment on attachment 342184 [details]
Patch v1

Oh dear.  Older compilers don't realize this method doesn't return!

[David Kilzer (:ddkilzer)]

Created attachment 342185 [details]
Patch v2

[Saam Barati]

Comment on attachment 342185 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=342185&action=review

> Source/bmalloc/bmalloc/BCompiler.h:51
> +#if defined(_MSC_VER)
> +#define BCOMPILER_MSVC 1
> +#endif

Why do we care about this? We don't compile bmalloc on windows AFAIK.

[David Kilzer (:ddkilzer)]

(In reply to Saam Barati from comment #4)
> Comment on attachment 342185 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342185&action=review
> 
> > Source/bmalloc/bmalloc/BCompiler.h:51
> > +#if defined(_MSC_VER)
> > +#define BCOMPILER_MSVC 1
> > +#endif
> 
> Why do we care about this? We don't compile bmalloc on windows AFAIK.

I was porting the WTF_NO_RETURN macro over will full fidelity.  If we don't compile bmalloc for Windows, then yes, we can leave this out.

[David Kilzer (:ddkilzer)]

Created attachment 342199 [details]
Patch v3

[WebKit Commit Bot]

Comment on attachment 342199 [details]
Patch v3

Clearing flags on attachment: 342199

Committed r232599: <https://trac.webkit.org/changeset/232599>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40909586>