Bug 186398 - [Cocoa] Turn on ARC for the single Objective-C++ source file in bmalloc
Summary: [Cocoa] Turn on ARC for the single Objective-C++ source file in bmalloc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-07 09:22 PDT by Darin Adler
Modified: 2018-06-08 10:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.90 KB, patch)
2018-06-07 09:23 PDT, Darin Adler 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-06-07 09:22:23 PDT 
[Cocoa] Turn on ARC for the single Objective-C++ source file in bmalloc
Comment 1 Darin Adler 2018-06-07 09:23:51 PDT 
Created attachment 342175 [details]
Patch
Comment 2 Darin Adler 2018-06-07 09:25:38 PDT 
Comment on attachment 342175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342175&action=review

> Source/bmalloc/bmalloc/ProcessCheck.mm:37
> +    // If we wanted to make it efficient to call mroe than once, we could memoize the result in a global boolean.

Oops, I’ll fix my "mroe" typo.
Comment 3 Darin Adler 2018-06-08 10:24:06 PDT 
Committed r232626: <https://trac.webkit.org/changeset/232626>
Comment 4 Radar WebKit Bug Importer 2018-06-08 10:25:20 PDT 
<rdar://problem/40941316>