Bug 186394 - [LFC] Merge height and vertical margin computation
Summary: [LFC] Merge height and vertical margin computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-07 07:39 PDT by zalan
Modified: 2018-06-07 08:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (22.63 KB, patch)
2018-06-07 07:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-06-07 07:39:14 PDT 
similar to width and horizontal margin computation
Comment 1 zalan 2018-06-07 07:51:00 PDT 
Created attachment 342163 [details]
Patch
Comment 2 zalan 2018-06-07 07:53:33 PDT 
Comment on attachment 342163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342163&action=review

> Source/WebCore/layout/FormattingContext.h:92
> +        struct HeightAndMargin {
> +            LayoutUnit height;
> +            Display::Box::VerticalEdges margin;
> +        };

I also tried
struct SizeAndMargin {
    std::optional<LayoutUnit> width;
    std::optional<LayoutUnit> height;
    std::optional<Display::Box::VerticalEdges> verticalMargin;
    std::optional<Display::Box::HorizontalEdges> horizontalMargin;
};
but it turned out to be too confusing with all the std::nullopts.
Comment 3 WebKit Commit Bot 2018-06-07 08:39:13 PDT 
Comment on attachment 342163 [details]
Patch

Clearing flags on attachment: 342163

Committed r232581: <https://trac.webkit.org/changeset/232581>
Comment 4 WebKit Commit Bot 2018-06-07 08:39:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-07 08:40:23 PDT 
<rdar://problem/40895938>