RESOLVED FIXED 186394
[LFC] Merge height and vertical margin computation 
https://bugs.webkit.org/show_bug.cgi?id=186394
Summary [LFC] Merge height and vertical margin computation
zalan
Reported 2018-06-07 07:39:14 PDT
similar to width and horizontal margin computation
Attachments
Patch (22.63 KB, patch)
2018-06-07 07:51 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-06-07 07:51:00 PDT
Created attachment 342163 [details] Patch
zalan
Comment 2 2018-06-07 07:53:33 PDT
Comment on attachment 342163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342163&action=review > Source/WebCore/layout/FormattingContext.h:92 > + struct HeightAndMargin { > + LayoutUnit height; > + Display::Box::VerticalEdges margin; > + }; I also tried struct SizeAndMargin { std::optional<LayoutUnit> width; std::optional<LayoutUnit> height; std::optional<Display::Box::VerticalEdges> verticalMargin; std::optional<Display::Box::HorizontalEdges> horizontalMargin; }; but it turned out to be too confusing with all the std::nullopts.
WebKit Commit Bot
Comment 3 2018-06-07 08:39:13 PDT
Comment on attachment 342163 [details] Patch Clearing flags on attachment: 342163 Committed r232581: <https://trac.webkit.org/changeset/232581>
WebKit Commit Bot
Comment 4 2018-06-07 08:39:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-06-07 08:40:23 PDT
<rdar://problem/40895938>
Note You need to log in before you can comment on or make changes to this bug.