Bug 186387 - [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a MainWindow's method
Summary: [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a MainWindo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 184770
  Show dependency tree / graph
 
Reported: 2018-06-07 01:20 PDT by Fujii Hironori
Modified: 2018-06-07 19:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.59 KB, patch)
2018-06-07 01:26 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (7.07 KB, patch)
2018-06-07 19:13 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-06-07 01:20:33 PDT 
[Win][MiniBrowser] Convert MiniBrowser::updateDeviceScaleFactor to a MainWindow's method

MiniBrowser::updateDeviceScaleFactor does nothing for MiniBrowser.
It should be a MainWindow's method.
Comment 1 Fujii Hironori 2018-06-07 01:26:46 PDT 
Created attachment 342139 [details]
Patch
Comment 2 Ryosuke Niwa 2018-06-07 13:15:14 PDT 
Comment on attachment 342139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342139&action=review

> Tools/MiniBrowser/win/MainWindow.cpp:426
> +    m_hURLBarFont = ::CreateFont(scaleFactor * 18, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, DEFAULT_CHARSET,

Where did 18 come from!?
Comment 3 Fujii Hironori 2018-06-07 18:54:23 PDT 
Comment on attachment 342139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342139&action=review

Thank you very much for the review.

>> Tools/MiniBrowser/win/MainWindow.cpp:426
>> +    m_hURLBarFont = ::CreateFont(scaleFactor * 18, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, DEFAULT_CHARSET,
> 
> Where did 18 come from!?

Good question! urlBarHeight is 24. It should be urlBarHeight * 3.0 / 4.
Comment 4 Fujii Hironori 2018-06-07 19:13:21 PDT 
Created attachment 342230 [details]
Patch
Comment 5 Fujii Hironori 2018-06-07 19:20:00 PDT 
Committed r232609: <https://trac.webkit.org/changeset/232609>
Comment 6 Radar WebKit Bug Importer 2018-06-07 19:20:21 PDT 
<rdar://problem/40920937>