Bug 186379 - Run display links in the UI process when ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) is true.
Summary: Run display links in the UI process when ENABLE(WEBPROCESS_WINDOWSERVER_BLOCK...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-06 19:39 PDT by Per Arne Vollan
Modified: 2018-06-08 11:45 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.04 KB, patch)
2018-06-06 19:43 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (5.20 KB, patch)
2018-06-06 19:51 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (5.43 KB, patch)
2018-06-06 20:11 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff
Patch (5.44 KB, patch)
2018-06-06 20:18 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch for landing (6.46 KB, patch)
2018-06-08 10:36 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-06-06 19:39:38 PDT
Replace __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 with ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING).
Comment 1 Per Arne Vollan 2018-06-06 19:43:22 PDT
Created attachment 342106 [details]
Patch
Comment 2 Per Arne Vollan 2018-06-06 19:51:36 PDT
Created attachment 342108 [details]
Patch
Comment 3 Per Arne Vollan 2018-06-06 20:11:33 PDT
Created attachment 342110 [details]
Patch
Comment 4 Per Arne Vollan 2018-06-06 20:18:58 PDT
Created attachment 342112 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2018-06-08 10:00:14 PDT
<rdar://problem/40940236>
Comment 6 Brent Fulgham 2018-06-08 10:19:45 PDT
Comment on attachment 342110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342110&action=review

Looks good.

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:29
> +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

I wonder if we need the PLATFORM(MAC) here, since this is a Mac-specific file I think.

> Source/WebKit/UIProcess/mac/DisplayLink.h:28
> +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

Ditto.

> Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp:41
> +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

Again, I wonder if PLATFORM(MAC) is necessary in this Mac-specific file.
Comment 7 Per Arne Vollan 2018-06-08 10:34:19 PDT
(In reply to Brent Fulgham from comment #6)
> Comment on attachment 342110 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342110&action=review
> 
> Looks good.
> 
> > Source/WebKit/UIProcess/mac/DisplayLink.cpp:29
> > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
> 
> I wonder if we need the PLATFORM(MAC) here, since this is a Mac-specific
> file I think.
> 
> > Source/WebKit/UIProcess/mac/DisplayLink.h:28
> > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
> 
> Ditto.
> 
> > Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp:41
> > +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
> 
> Again, I wonder if PLATFORM(MAC) is necessary in this Mac-specific file.

Thanks for reviewing! I will update the patch before landing.
Comment 8 Per Arne Vollan 2018-06-08 10:36:10 PDT
Created attachment 342288 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2018-06-08 11:45:58 PDT
Comment on attachment 342288 [details]
Patch for landing

Clearing flags on attachment: 342288

Committed r232634: <https://trac.webkit.org/changeset/232634>