Replace __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 with ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING).
Created attachment 342106 [details] Patch
Created attachment 342108 [details] Patch
Created attachment 342110 [details] Patch
Created attachment 342112 [details] Patch
<rdar://problem/40940236>
Comment on attachment 342110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342110&action=review Looks good. > Source/WebKit/UIProcess/mac/DisplayLink.cpp:29 > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) I wonder if we need the PLATFORM(MAC) here, since this is a Mac-specific file I think. > Source/WebKit/UIProcess/mac/DisplayLink.h:28 > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) Ditto. > Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp:41 > +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) Again, I wonder if PLATFORM(MAC) is necessary in this Mac-specific file.
(In reply to Brent Fulgham from comment #6) > Comment on attachment 342110 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342110&action=review > > Looks good. > > > Source/WebKit/UIProcess/mac/DisplayLink.cpp:29 > > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > I wonder if we need the PLATFORM(MAC) here, since this is a Mac-specific > file I think. > > > Source/WebKit/UIProcess/mac/DisplayLink.h:28 > > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > Ditto. > > > Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp:41 > > +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > Again, I wonder if PLATFORM(MAC) is necessary in this Mac-specific file. Thanks for reviewing! I will update the patch before landing.
Created attachment 342288 [details] Patch for landing
Comment on attachment 342288 [details] Patch for landing Clearing flags on attachment: 342288 Committed r232634: <https://trac.webkit.org/changeset/232634>