Bug 186376 - Use the same overloaded addInputString in WKContentViewInteraction
Summary: Use the same overloaded addInputString in WKContentViewInteraction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-06 18:11 PDT by Jiewen Tan
Modified: 2018-06-07 12:48 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2018-06-06 18:32 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.82 MB, application/zip)
2018-06-06 23:40 PDT, EWS Watchlist 		no flags Details
Patch for landing (1.93 KB, patch)
2018-06-07 12:09 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-06-06 18:11:28 PDT 
It turns out that different addInputString overloads behave differently. We should use the same overload version consistently:
[UIKeyboardImpl -addInputString:withFlags:withInputManagerHint:].
Comment 1 Jiewen Tan 2018-06-06 18:11:50 PDT 
<rdar://problem/18498360>
Comment 2 Jiewen Tan 2018-06-06 18:32:25 PDT 
Created attachment 342104 [details]
Patch
Comment 3 EWS Watchlist 2018-06-06 23:39:53 PDT 
Comment on attachment 342104 [details]
Patch

Attachment 342104 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8046892

New failing tests:
http/tests/preload/onload_event.html
Comment 4 EWS Watchlist 2018-06-06 23:40:04 PDT 
Created attachment 342127 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Jiewen Tan 2018-06-07 10:25:30 PDT 
The tree of win EWS bot is red. Should not blame this patch.
Comment 6 Brent Fulgham 2018-06-07 10:51:56 PDT 
Comment on attachment 342104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342104&action=review

r=me! Nice find.

> Source/WebKit/ChangeLog:10
> +        overloaded varaint consistently: [UIKeyboardImpl -addInputString:withFlags:withInputManagerHint:].

variant (the I/a are transposed)
Comment 7 Jiewen Tan 2018-06-07 12:09:00 PDT 
Created attachment 342198 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-06-07 12:48:53 PDT 
Comment on attachment 342198 [details]
Patch for landing

Clearing flags on attachment: 342198

Committed r232595: <https://trac.webkit.org/changeset/232595>
Comment 9 WebKit Commit Bot 2018-06-07 12:48:55 PDT 
All reviewed patches have been landed.  Closing bug.