Bug 186374 - [CoordGraphics] Fix compilation errors around USE(COORDINATED_GRAPHICS)
Summary: [CoordGraphics] Fix compilation errors around USE(COORDINATED_GRAPHICS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 186364
  Show dependency treegraph
 
Reported: 2018-06-06 17:54 PDT by Don Olmstead
Modified: 2018-06-07 11:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.51 KB, patch)
2018-06-06 17:56 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-06-06 17:54:38 PDT
There are a few cases around PLATFORM, USE and ENABLE that prevent compilation of a platform wanting to enable CoordinatedGraphics.

Encountered these while seeing what needed to be done to get WinCairo using CoordinatedGraphics.
Comment 1 Don Olmstead 2018-06-06 17:56:32 PDT
Created attachment 342100 [details]
Patch
Comment 2 Build Bot 2018-06-06 17:59:25 PDT
Attachment 342100 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:273:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-06-07 11:36:53 PDT
Comment on attachment 342100 [details]
Patch

Clearing flags on attachment: 342100

Committed r232590: <https://trac.webkit.org/changeset/232590>
Comment 4 WebKit Commit Bot 2018-06-07 11:36:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-07 11:37:19 PDT
<rdar://problem/40903814>