Bug 186369 – Add logging around internalError(const URL&)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Keith Rollin]

There are times when we receive bug reports where the user says that they are simply shown a page saying an internal error occurred. To help understand the circumstances of that error, add some logging to internalError() in WebErrors.cpp. This logging logs at the Error level that internalError() was called and then logs a backtrace.

[Radar WebKit Bug Importer]

<rdar://problem/40872046>

[Keith Rollin]

Created attachment 342090 [details]
Patch

[Keith Rollin]

Created attachment 342094 [details]
Fix build error

[Brent Fulgham]

Comment on attachment 342094 [details]
Fix build error

View in context: https://bugs.webkit.org/attachment.cgi?id=342094&action=review

Looks good! I suggest the modern C++ loop.

> Source/WTF/wtf/Assertions.cpp:556
> +        for (int frameNumber = 1; frameNumber < stackTrace->size(); ++frameNumber) {

Could this be a modern C++ loop?

for (auto stackFrame : stackTrace->stack()) {
   ...

[Brent Fulgham]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 342094 [details]
> Fix build error
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342094&action=review
> 
> Looks good! I suggest the modern C++ loop.
> 
> > Source/WTF/wtf/Assertions.cpp:556
> > +        for (int frameNumber = 1; frameNumber < stackTrace->size(); ++frameNumber) {
> 
> Could this be a modern C++ loop?
> 
> for (auto stackFrame : stackTrace->stack()) {
>    ...

I spoke with Keith in person, and realized that we need the index for logging. So never mind!

[WebKit Commit Bot]

Comment on attachment 342094 [details]
Fix build error

Clearing flags on attachment: 342094

Committed r232734: <https://trac.webkit.org/changeset/232734>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.