Bug 186350 - Wrong NSVisualEffectMaterial used for exit full screen overlay in dark mode
Summary: Wrong NSVisualEffectMaterial used for exit full screen overlay in dark mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-06 08:26 PDT by Timothy Hatcher
Modified: 2018-06-06 09:42 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2018-06-06 08:28 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2018-06-06 08:36 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-06-06 08:26:05 PDT
The  material is used. It needs to be one of the new semantic materials to work in dark mode.
Comment 1 Timothy Hatcher 2018-06-06 08:26:14 PDT
<rdar://problem/39135535>
Comment 2 Timothy Hatcher 2018-06-06 08:28:39 PDT
Created attachment 342047 [details]
Patch
Comment 3 Timothy Hatcher 2018-06-06 08:36:40 PDT
Created attachment 342048 [details]
Patch
Comment 4 WebKit Commit Bot 2018-06-06 09:42:11 PDT
Comment on attachment 342048 [details]
Patch

Clearing flags on attachment: 342048

Committed r232546: <https://trac.webkit.org/changeset/232546>
Comment 5 WebKit Commit Bot 2018-06-06 09:42:12 PDT
All reviewed patches have been landed.  Closing bug.