NEW 186338
[GTK] Crash in _ZNKSt14default_deleteIN6WebKit18IconDatabaseClientEEclEPS1_
https://bugs.webkit.org/show_bug.cgi?id=186338
Summary [GTK] Crash in _ZNKSt14default_deleteIN6WebKit18IconDatabaseClientEEclEPS1_
Cédric Bellegarde
Reported 2018-06-05 23:58:49 PDT
Created attachment 342038 [details] thread apply all bt full Happened while going back in navigation (and current page was not fully loaded).
Attachments
thread apply all bt full (109.89 KB, text/plain)
2018-06-05 23:58 PDT, Cédric Bellegarde
no flags
Michael Catanzaro
Comment 1 2018-06-06 08:54:08 PDT
I don't see the problem... it's really odd that eolie is creating a new WebKitWebContext during a navigation, but it should have its own separate WebKitFaviconDatabase with its own separate icon database thread. I see an icon database thread is running already, but that should not be concerning because it should be separate.
Cédric Bellegarde
Comment 2 2018-06-08 01:26:56 PDT
Eolie does not create a new WebKitWebContext during a navigation, only when creating a new webview. I see WEBKIT_POLICY_DECISION_TYPE_NEW_WINDOW_ACTION in the log so I guess that maybe clicking on the back button happened while current view was creating a new WebView, no?
Cédric Bellegarde
Comment 3 2018-09-26 03:51:48 PDT
Ok, I'm no sure when I'm calling set_favicon_database_directory() from a new WebKit2.WebContext(). In Eolie, each webview own a context so I'm able to change cookie manager persistent storage => Profiles like in Firefox.
Cédric Bellegarde
Comment 4 2018-09-26 05:00:18 PDT
Cédric Bellegarde
Comment 5 2018-09-29 09:28:51 PDT
Can confirm that crash comes only from this function: set_favicon_database_directory() Looks like WebKit2GTK really needs this to be called only one time. Not an issue for a normal browser but Eolie was creating a Context per WebView allowing me to have differents cookie managers per WebView (profiles like in Firefox) It's not a blocking issue but it was a cool feature from Eolie: - Go to google.fr => disconnected from google - Go to plus.google.fr => connected to google - etc...
Note You need to log in before you can comment on or make changes to this bug.