Bug 186337 - [LFC] Add margin computation for floating, replaced elements.
Summary: [LFC] Add margin computation for floating, replaced elements.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2018-06-05 21:46 PDT by zalan
Modified: 2018-06-06 08:53 PDT (History)
6 users (show)

See Also:

Patch (5.28 KB, patch)
2018-06-05 22:09 PDT, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-06-05 21:46:28 PDT
If 'margin-left' or 'margin-right' are computed as 'auto', their used value is '0'.
Comment 1 zalan 2018-06-05 22:09:47 PDT
Created attachment 342033 [details]
Comment 2 Antti Koivisto 2018-06-06 07:50:20 PDT
Comment on attachment 342033 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=342033&action=review

> Source/WebCore/layout/FormattingContext.h:98
> +        static WidthAndMargin inlineReplacedWidthAndMargin(LayoutContext&, const Box&, std::optional<LayoutUnit> precomputedMarginLeft = std::nullopt,

I think you can do { } instead of std::nullopt if you want to be more compact.

> Source/WebCore/layout/FormattingContextGeometry.cpp:557
>      LayoutUnit computedMarginRightValue;

Maybe this stuff would look nicer as a lambda?

auto computedMarginRightValue = computeMarginRight();

You would avoid else branches.

> Source/WebCore/layout/FormattingContextGeometry.cpp:572
> +            computedMarginRightValue = marginRight.isAuto() ? LayoutUnit { 0 }: valueForLength(marginRight, containingBlockWidth);

Missing space before :
Comment 3 zalan 2018-06-06 08:52:22 PDT
Committed r232541: <https://trac.webkit.org/changeset/232541>
Comment 4 Radar WebKit Bug Importer 2018-06-06 08:53:22 PDT