Bug 186331 - Regression(r232082): Websites get loaded inside of Messages App chat transcript
Summary: Regression(r232082): Websites get loaded inside of Messages App chat transcript
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 185832
  Show dependency tree / graph
 
Reported: 2018-06-05 18:29 PDT by Chris Dumez
Modified: 2018-06-05 21:53 PDT (History)
8 users (show)

See Also:

Attachments
Patch (15.38 KB, patch)
2018-06-05 18:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-05 18:29:34 PDT 
Websites get loaded inside of Messages App chat transcript since https://trac.webkit.org/changeset/232082.
Comment 1 Chris Dumez 2018-06-05 18:30:00 PDT 
<rdar://problem/40735446>
Comment 2 Chris Dumez 2018-06-05 18:37:42 PDT 
Created attachment 342018 [details]
Patch
Comment 3 EWS Watchlist 2018-06-05 18:39:55 PDT 
Attachment 342018 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:869:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:901:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:913:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2018-06-05 21:53:40 PDT 
Comment on attachment 342018 [details]
Patch

Clearing flags on attachment: 342018

Committed r232536: <https://trac.webkit.org/changeset/232536>
Comment 5 Chris Dumez 2018-06-05 21:53:41 PDT 
All reviewed patches have been landed.  Closing bug.