Bug 186328 - Set the AVAssetResourceLoaderRequest's contentType to AVStreamingKeyDeliveryContentKeyType in the case of a FPS key request.
Summary: Set the AVAssetResourceLoaderRequest's contentType to AVStreamingKeyDeliveryC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-05 16:44 PDT by Jer Noble
Modified: 2018-06-06 09:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.01 KB, patch)
2018-06-05 16:47 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (3.00 KB, patch)
2018-06-05 21:23 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-06-05 16:44:18 PDT
Set the AVAssetResourceLoaderRequest's contentType to AVStreamingKeyDeliveryContentKeyType in the case of a FPS key request.
Comment 1 Radar WebKit Bug Importer 2018-06-05 16:44:53 PDT
<rdar://problem/40829228>
Comment 2 Jer Noble 2018-06-05 16:47:11 PDT
Created attachment 342006 [details]
Patch
Comment 3 Eric Carlson 2018-06-05 20:50:20 PDT
Comment on attachment 342006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342006&action=review

r=me once the bots are happy.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2492
> +            infoRequest.contentType = AVStreamingKeyDeliveryContentKeyType;

Is this string available in every version is the OS we support?
Comment 4 Jer Noble 2018-06-05 20:55:39 PDT
Comment on attachment 342006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342006&action=review

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2492
>> +            infoRequest.contentType = AVStreamingKeyDeliveryContentKeyType;
> 
> Is this string available in every version is the OS we support?

This is wrapped in a ENABLE(ENCRYPTED_MEDIA) check, which is only enabled on platforms which will deliver this string.
Comment 5 Jer Noble 2018-06-05 21:23:10 PDT
Created attachment 342029 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-06-06 09:10:53 PDT
Comment on attachment 342029 [details]
Patch for landing

Clearing flags on attachment: 342029

Committed r232542: <https://trac.webkit.org/changeset/232542>
Comment 7 WebKit Commit Bot 2018-06-06 09:10:55 PDT
All reviewed patches have been landed.  Closing bug.