Bug 186326 – REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in

[Jer Noble]

<rdar://problem/40778157>

[Jer Noble]

Created attachment 342003 [details]
Patch

[EWS Watchlist]

Comment on attachment 342003 [details]
Patch

Attachment 342003 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/8019956

New failing tests:
media/video-buffering-allowed.html

[EWS Watchlist]

Created attachment 342009 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 342003 [details]
Patch

Attachment 342003 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8020041

New failing tests:
media/video-buffering-allowed.html

[EWS Watchlist]

Created attachment 342010 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 342003 [details]
Patch

Attachment 342003 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8020305

New failing tests:
media/video-buffering-allowed.html

[EWS Watchlist]

Created attachment 342013 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 342003 [details]
Patch

Attachment 342003 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/8020289

New failing tests:
media/video-buffering-allowed.html

[EWS Watchlist]

Created attachment 342014 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Jer Noble]

Created attachment 342017 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 342017 [details]
Patch

Clearing flags on attachment: 342017

Committed r232534: <https://trac.webkit.org/changeset/232534>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

media/video-buffering-allowed.html was flaky since it was added in https://trac.webkit.org/changeset/231817/webkit, but after this change it is failing very frequently on macOS debug bots.

--- /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/media/video-buffering-allowed-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/media/video-buffering-allowed-actual.txt
@@ -33,6 +33,6 @@
 EXPECTED (internals.elementShouldBufferData(video) == 'false') OK
 * Remove display:none from the video element.
 RUN(video.style.removeProperty("display"))
-EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
+FAIL: did not end fast enough
 END OF TEST


https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-buffering-allowed.html