Bug 186324 - [Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to other smart pointers
Summary: [Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-05 14:36 PDT by Darin Adler
Modified: 2018-06-05 17:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (23.25 KB, patch)
2018-06-05 14:42 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-06-05 14:36:17 PDT 
[Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to other smart pointers
Comment 1 Darin Adler 2018-06-05 14:42:59 PDT 
Created attachment 341996 [details]
Patch
Comment 2 Anders Carlsson 2018-06-05 14:45:20 PDT 
Comment on attachment 341996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341996&action=review

> Source/WTF/wtf/RetainPtr.h:118
> -#if defined (__OBJC__) && __has_feature(objc_arc)
> +#if __has_feature(objc_arc)

I think you might have to keep this in RetainPtr, unless __has_feature is defined away on Windows.
Comment 3 Darin Adler 2018-06-05 14:55:50 PDT 
Comment on attachment 341996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341996&action=review

>> Source/WTF/wtf/RetainPtr.h:118
>> +#if __has_feature(objc_arc)
> 
> I think you might have to keep this in RetainPtr, unless __has_feature is defined away on Windows.

All right. I will.

Or I could use COMPILER_HAS_CLANG_FEATURE. But I will just leave this unmodified. Even though the space after "defined" drives me a little nuts.
Comment 4 Darin Adler 2018-06-05 17:18:33 PDT 
Committed r232528: <https://trac.webkit.org/changeset/232528>
Comment 5 Radar WebKit Bug Importer 2018-06-05 17:19:24 PDT 
<rdar://problem/40830436>