WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
186324
[Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to other smart pointers
https://bugs.webkit.org/show_bug.cgi?id=186324
Summary
[Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to o...
Darin Adler
Reported
2018-06-05 14:36:17 PDT
[Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to other smart pointers
Attachments
Patch
(23.25 KB, patch)
2018-06-05 14:42 PDT
,
Darin Adler
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2018-06-05 14:42:59 PDT
Created
attachment 341996
[details]
Patch
Anders Carlsson
Comment 2
2018-06-05 14:45:20 PDT
Comment on
attachment 341996
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=341996&action=review
> Source/WTF/wtf/RetainPtr.h:118 > -#if defined (__OBJC__) && __has_feature(objc_arc) > +#if __has_feature(objc_arc)
I think you might have to keep this in RetainPtr, unless __has_feature is defined away on Windows.
Darin Adler
Comment 3
2018-06-05 14:55:50 PDT
Comment on
attachment 341996
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=341996&action=review
>> Source/WTF/wtf/RetainPtr.h:118 >> +#if __has_feature(objc_arc) > > I think you might have to keep this in RetainPtr, unless __has_feature is defined away on Windows.
All right. I will. Or I could use COMPILER_HAS_CLANG_FEATURE. But I will just leave this unmodified. Even though the space after "defined" drives me a little nuts.
Darin Adler
Comment 4
2018-06-05 17:18:33 PDT
Committed
r232528
: <
https://trac.webkit.org/changeset/232528
>
Radar WebKit Bug Importer
Comment 5
2018-06-05 17:19:24 PDT
<
rdar://problem/40830436
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug