Bug 18632 - SQUIRRELFISH: need split window support
Summary: SQUIRRELFISH: need split window support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks: 18631
  Show dependency treegraph
 
Reported: 2008-04-19 16:31 PDT by Maciej Stachowiak
Modified: 2008-04-24 06:20 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2008-04-19 16:31:02 PDT
One of the issues that affects many of the layout tests on the SquirrelFish branch (as well as much real browsing) is the fact that split window support is not merged quite right. This results in crashes that look like this (observed, for instance, on media/video-controls.html and also on GMail):

ASSERTION FAILED: !thisObj->inherits(&JSDOMWindow::s_info)
(/Volumes/Data/mjs/Work/src/Safari/OpenSource/WebCore/bindings/js/JSDOMWindowBase.cpp:1131 KJS::JSValue* WebCore::windowProtoFuncSetTimeout(KJS::ExecState*, KJS::JSObject*, const KJS::List&))
Comment 1 Maciej Stachowiak 2008-04-24 00:49:31 PDT
As far as I can tell, this mostly works now though some details may be wrong.
Comment 2 Adam Barth 2008-04-24 04:21:52 PDT
Is there a specific change that fixed this bug?