Bug 186303 - [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies aren't flushed to file
Summary: [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-04 23:23 PDT by Sihui Liu
Modified: 2018-06-05 15:09 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.78 KB, patch)
2018-06-04 23:31 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-06-04 23:23:41 PDT 
Here is the failure output now:

    TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool

        /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:471
        Value of: message.UTF8String
          Actual: "SessionCookieName=CookieValue"
        Expected: "PersistentCookieName=CookieValue; SessionCookieName=CookieValue"

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/5348/steps/run-api-tests/logs/stdio
Comment 1 Sihui Liu 2018-06-04 23:24:23 PDT 
<rdar://problem/40468716>
Comment 2 Sihui Liu 2018-06-04 23:31:41 PDT 
Created attachment 341956 [details]
Patch
Comment 3 Geoffrey Garen 2018-06-05 14:43:38 PDT 
Comment on attachment 341956 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-06-05 15:09:53 PDT 
Comment on attachment 341956 [details]
Patch

Clearing flags on attachment: 341956

Committed r232522: <https://trac.webkit.org/changeset/232522>
Comment 5 WebKit Commit Bot 2018-06-05 15:09:55 PDT 
All reviewed patches have been landed.  Closing bug.