Bug 186299 – Add the basic support for writing components in node.js

• Status: RESOLVED
• Resolution: FIXED
• Component: Perf Dashboard

[Ryosuke Niwa]

For the purpose of rewriting change detection scripts & email notifications using v3 code,
it would be extremely useful to be able to write & run components in node.js.

[Ryosuke Niwa]

Created attachment 342030 [details]
Adds MarkupComponentBase and MarkupPage

[EWS Watchlist]

Comment on attachment 342030 [details]
Adds MarkupComponentBase and MarkupPage

Attachment 342030 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8027573

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html

[EWS Watchlist]

Created attachment 342040 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment on attachment 342030 [details]
Adds MarkupComponentBase and MarkupPage

View in context: https://bugs.webkit.org/attachment.cgi?id=342030&action=review

> Websites/perf.webkit.org/tools/js/markup-component.js:361
> +class MarkupComponentBase extends CommonComponentBase {

Do we need to import CommonComponentBase in this class for node environment?

[Ryosuke Niwa]

(In reply to dewei_zhu from comment #4)
> Comment on attachment 342030 [details]
> Adds MarkupComponentBase and MarkupPage
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342030&action=review
> 
> > Websites/perf.webkit.org/tools/js/markup-component.js:361
> > +class MarkupComponentBase extends CommonComponentBase {
> 
> Do we need to import CommonComponentBase in this class for node environment?

Yes, do that where this is used.

[Ryosuke Niwa]

Created attachment 342093 [details]
Fixed a bug

[Ryosuke Niwa]

Committed r232588: <https://trac.webkit.org/changeset/232588>

[Radar WebKit Bug Importer]

<rdar://problem/40903267>