Bug 186299 - Add the basic support for writing components in node.js
Summary: Add the basic support for writing components in node.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 184340
  Show dependency treegraph
 
Reported: 2018-06-04 22:22 PDT by Ryosuke Niwa
Modified: 2018-06-07 11:27 PDT (History)
6 users (show)

See Also:


Attachments
Adds MarkupComponentBase and MarkupPage (113.41 KB, patch)
2018-06-05 21:27 PDT, Ryosuke Niwa
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.74 MB, application/zip)
2018-06-06 02:35 PDT, EWS Watchlist
no flags Details
Fixed a bug (114.66 KB, patch)
2018-06-06 16:32 PDT, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-06-04 22:22:02 PDT
For the purpose of rewriting change detection scripts & email notifications using v3 code,
it would be extremely useful to be able to write & run components in node.js.
Comment 1 Ryosuke Niwa 2018-06-05 21:27:35 PDT
Created attachment 342030 [details]
Adds MarkupComponentBase and MarkupPage
Comment 2 EWS Watchlist 2018-06-06 02:35:25 PDT
Comment on attachment 342030 [details]
Adds MarkupComponentBase and MarkupPage

Attachment 342030 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8027573

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html
Comment 3 EWS Watchlist 2018-06-06 02:35:36 PDT
Created attachment 342040 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 dewei_zhu 2018-06-06 16:04:04 PDT
Comment on attachment 342030 [details]
Adds MarkupComponentBase and MarkupPage

View in context: https://bugs.webkit.org/attachment.cgi?id=342030&action=review

> Websites/perf.webkit.org/tools/js/markup-component.js:361
> +class MarkupComponentBase extends CommonComponentBase {

Do we need to import CommonComponentBase in this class for node environment?
Comment 5 Ryosuke Niwa 2018-06-06 16:21:52 PDT
(In reply to dewei_zhu from comment #4)
> Comment on attachment 342030 [details]
> Adds MarkupComponentBase and MarkupPage
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342030&action=review
> 
> > Websites/perf.webkit.org/tools/js/markup-component.js:361
> > +class MarkupComponentBase extends CommonComponentBase {
> 
> Do we need to import CommonComponentBase in this class for node environment?

Yes, do that where this is used.
Comment 6 Ryosuke Niwa 2018-06-06 16:32:22 PDT
Created attachment 342093 [details]
Fixed a bug
Comment 7 Ryosuke Niwa 2018-06-07 11:25:37 PDT
Committed r232588: <https://trac.webkit.org/changeset/232588>
Comment 8 Radar WebKit Bug Importer 2018-06-07 11:27:09 PDT
<rdar://problem/40903267>