Bug 186293 – run-testmem should have a dry run option and an option to parse the stdout of executing the dry run

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

So it can create a bunch of commands for me and I can run it on a device that doesn't have a ruby

[Saam Barati]

Created attachment 341976 [details]
patch

[Joseph Pecoraro]

Comment on attachment 341976 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341976&action=review

> Tools/Scripts/run-testmem:40
> +    puts "--parse       (-p)   After executing the dry run, capture its stdout and write it to a file. Pass the path to that file for this option and run-testmem will compute the results of the benchmark run."
> +    puts "--help        (-h)   print this message"

Some of these start with a capital and end in a period, some don't. Should be consistent.

> Tools/Scripts/run-testmem:261
> +

Nit: drop empty line

[Saam Barati]

Created attachment 341978 [details]
patch

[Saam Barati]

(In reply to Saam Barati from comment #3)
> Created attachment 341978 [details]
> patch

Addressed Joe's comments.

[Mark Lam]

Comment on attachment 341976 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341976&action=review

r=me with fixes.

> Tools/Scripts/run-testmem:138
>          filePath = dirPath.join(filename).to_s
> +        filePath = Pathname.new($scriptPath).join(filename).to_s if $scriptPath

I think line 137 is unnecessary now.

[Mark Lam]

Comment on attachment 341976 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341976&action=review

>> Tools/Scripts/run-testmem:138
>> +        filePath = Pathname.new($scriptPath).join(filename).to_s if $scriptPath
> 
> I think line 137 is unnecessary now.

Oops, never mind.  I missed the "if $scriptPath".  Line 137 is necessary.

[WebKit Commit Bot]

Comment on attachment 341978 [details]
patch

Clearing flags on attachment: 341978

Committed r232517: <https://trac.webkit.org/changeset/232517>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40817463>