RESOLVED FIXED 186289
AR Badging on transparent thumbnail images makes the glyph look really dark 
https://bugs.webkit.org/show_bug.cgi?id=186289
Summary AR Badging on transparent thumbnail images makes the glyph look really dark
Dean Jackson
Reported 2018-06-04 16:07:02 PDT
AR Badging on transparent thumbnail images makes the glyph look really dark
Attachments
Patch (6.71 KB, patch)
2018-06-04 16:40 PDT, Dean Jackson 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2018-06-04 16:37:19 PDT
<rdar://problem/40627111>
Dean Jackson
Comment 2 2018-06-04 16:40:16 PDT
Created attachment 341936 [details] Patch
Anders Carlsson
Comment 3 2018-06-04 16:42:35 PDT
Comment on attachment 341936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1874 > + // Clip out the circle to only show the shadow Please add a period to the end of the sentence. > Source/WebCore/rendering/RenderThemeIOS.mm:1876 > + CGRect imageRect = static_cast<CGRect>(rect); Can this be CGRect imageRect { rect }; ?
Dean Jackson
Comment 4 2018-06-04 17:09:13 PDT
Comment on attachment 341936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review >> Source/WebCore/rendering/RenderThemeIOS.mm:1876 >> + CGRect imageRect = static_cast<CGRect>(rect); > > Can this be CGRect imageRect { rect }; ? I didn't even need this. I can just autocast from IntRect.
Dean Jackson
Comment 5 2018-06-04 17:09:30 PDT
Committed r232487: <https://trac.webkit.org/changeset/232487>
Note You need to log in before you can comment on or make changes to this bug.