Bug 186289 - AR Badging on transparent thumbnail images makes the glyph look really dark
Summary: AR Badging on transparent thumbnail images makes the glyph look really dark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-04 16:07 PDT by Dean Jackson
Modified: 2018-06-04 17:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.71 KB, patch)
2018-06-04 16:40 PDT, Dean Jackson 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-06-04 16:07:02 PDT 
AR Badging on transparent thumbnail images makes the glyph look really dark
Comment 1 Dean Jackson 2018-06-04 16:37:19 PDT 
<rdar://problem/40627111>
Comment 2 Dean Jackson 2018-06-04 16:40:16 PDT 
Created attachment 341936 [details]
Patch
Comment 3 Anders Carlsson 2018-06-04 16:42:35 PDT 
Comment on attachment 341936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1874
> +    // Clip out the circle to only show the shadow

Please add a period to the end of the sentence.

> Source/WebCore/rendering/RenderThemeIOS.mm:1876
> +    CGRect imageRect = static_cast<CGRect>(rect);

Can this be CGRect imageRect { rect }; ?
Comment 4 Dean Jackson 2018-06-04 17:09:13 PDT 
Comment on attachment 341936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review

>> Source/WebCore/rendering/RenderThemeIOS.mm:1876
>> +    CGRect imageRect = static_cast<CGRect>(rect);
> 
> Can this be CGRect imageRect { rect }; ?

I didn't even need this. I can just autocast from IntRect.
Comment 5 Dean Jackson 2018-06-04 17:09:30 PDT 
Committed r232487: <https://trac.webkit.org/changeset/232487>