Bug 186287 – Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy".

[Radar WebKit Bug Importer]

<rdar://problem/40783352>

[Chris Dumez]

Created attachment 341927 [details]
Patch

[Chris Dumez]

Created attachment 341932 [details]
Patch

[youenn fablet]

Comment on attachment 341932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341932&action=review

> Source/WebCore/ChangeLog:9
> +        CrossOriginWindowPolicy

Not needed

> Source/WebCore/page/AbstractDOMWindow.cpp:41
>  AbstractDOMWindow::AbstractDOMWindow(GlobalWindowIdentifier&& identifier)

GlobalWindowIdentifier&& does not seem to bring any advantage over const GlobalWindowIdentifier& or is it special in some way?


> Source/WebCore/page/AbstractDOMWindow.h:57
> +    CrossOriginWindowPolicy crossOriginWindowPolicy() { return m_crossOriginWindowPolicy; }

const

> Source/WebCore/page/AbstractDOMWindow.h:69
> +    CrossOriginWindowPolicy m_crossOriginWindowPolicy;

Can we set the default value here instead of the constructor?

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:637
> +        [NSNumber numberWithBool:NO], WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey,

Should we set it to true by default for WK1 as well?

> Source/WebKitLegacy/win/WebPreferences.cpp:252
> +    CFDictionaryAddValue(defaults, CFSTR(WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey), kCFBooleanFalse);

Is there anything preventing us from aligning windows with other ports?

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:865
> +    [preferences setCrossOriginWindowPolicySupportEnabled:YES];

If we set it to true in Mac/win, we could remove these lines

[Chris Dumez]

Created attachment 341951 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 341951 [details]
Patch

Clearing flags on attachment: 341951

Committed r232499: <https://trac.webkit.org/changeset/232499>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.