Bug 186285 - Add iOS 12 and watchOS 5 to webkitpy
Summary: Add iOS 12 and watchOS 5 to webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-04 14:32 PDT by Jonathan Bedard
Modified: 2018-06-15 10:17 PDT (History)
7 users (show)

See Also:


Attachments
Patch (10.91 KB, patch)
2018-06-04 15:01 PDT, Jonathan Bedard
jbedard: commit-queue-
Details | Formatted Diff | Diff
Patch (14.81 KB, patch)
2018-06-07 09:28 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-06-04 14:32:27 PDT
Adds support for 2018 embedded Apple operating systems, namely iOS 12 and watchOS 5.
Comment 1 Jonathan Bedard 2018-06-04 15:01:44 PDT
Created attachment 341921 [details]
Patch
Comment 2 Alexey Proskuryakov 2018-06-04 15:43:14 PDT
This is one huge merge conflict with https://bugs.webkit.org/attachment.cgi?id=341917&action=review
Comment 3 Jonathan Bedard 2018-06-04 15:49:15 PDT
(In reply to Alexey Proskuryakov from comment #2)
> This is one huge merge conflict with
> https://bugs.webkit.org/attachment.cgi?id=341917&action=review

Yes.  I assumed that https://bugs.webkit.org/attachment.cgi?id=341917&action=review would land first.
Comment 4 Alexey Proskuryakov 2018-06-04 15:54:17 PDT
Comment on attachment 341921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341921&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py:40
> +    assert(target_platform in ("mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "win", "ios-11", "ios-simulator-11", "ios-12", "ios-simulator-12"))

Do we also need to add empty directories for test results? I believe that run-webkit-tests wants directories to exist.

> Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:43
> +        (["LayoutTests/platform/ios-simulator-wk1/foo"], ["ios-11", "ios-simulator-11", "ios-12", "ios-simulator-12"]),

We don't have any tests that verify what happens when checking in to version specific iOS directories. We should, especially if that works properly.
Comment 5 Jonathan Bedard 2018-06-07 09:28:19 PDT
Created attachment 342177 [details]
Patch
Comment 6 Jonathan Bedard 2018-06-07 09:31:24 PDT
attachment 342177 [details] adds tests for versions specific test expectations.

To address Alexey's comment about run-webkit-tests: No, run-webkit-tests does not require that test expectation directories exist.
Comment 7 WebKit Commit Bot 2018-06-15 10:17:00 PDT
Comment on attachment 342177 [details]
Patch

Clearing flags on attachment: 342177

Committed r232877: <https://trac.webkit.org/changeset/232877>
Comment 8 WebKit Commit Bot 2018-06-15 10:17:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-06-15 10:17:16 PDT
<rdar://problem/41163215>