Bug 186282 - Add Mojave support to WebKit tools
Summary: Add Mojave support to WebKit tools
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-04 13:50 PDT by Alexey Proskuryakov
Modified: 2018-06-04 15:50 PDT (History)
8 users (show)

See Also:


Attachments
proposed patch (176.99 KB, patch)
2018-06-04 13:55 PDT, Alexey Proskuryakov
dbates: review+
ap: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-06-04 13:50:28 PDT
Add macOS Mojave support to WebKit tools.
Comment 1 Alexey Proskuryakov 2018-06-04 13:55:51 PDT
Created attachment 341917 [details]
proposed patch
Comment 2 Daniel Bates 2018-06-04 15:45:52 PDT
Comment on attachment 341917 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341917&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:192
> +    content: -webkit-image-set(url(../Images/Mojave@2x.png) 2x, url(../Images/Mojave.png) 1x);

Mojave@2x.png is not included in this patch. Is this intentional?
Comment 3 Alexey Proskuryakov 2018-06-04 15:47:31 PDT
Not intentional, but expected - the "@" character is special in svn, so many tools fail when it's present. Thank you for the review!
Comment 4 Alexey Proskuryakov 2018-06-04 15:49:21 PDT
Committed http://trac.webkit.org/r232483.
Comment 5 Radar WebKit Bug Importer 2018-06-04 15:50:21 PDT
<rdar://problem/40784451>